From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Mon, 26 Aug 2019 15:03:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 15:03:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,433,1559545200"; d="scan'208";a="331614257" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 26 Aug 2019 15:03:37 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 15:03:36 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 15:03:35 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.65]) with mapi id 14.03.0439.000; Tue, 27 Aug 2019 06:03:34 +0800 From: "Ni, Ray" To: "afish@apple.com" , "Kinney, Michael D" CC: "devel@edk2.groups.io" , "tim.lewis@insyde.com" , "leif.lindholm@linaro.org" , "Justen, Jordan L" Subject: Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression Thread-Topic: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image unload regression Thread-Index: AQHVWJJepE5q5O7uJUOqwshLP6EgLKcNUoKAgACXaeD//4GTgIAAAn4AgACU9aA= Date: Mon, 26 Aug 2019 22:03:34 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C29CA64@SHSMSX104.ccr.corp.intel.com> References: <20190822023610.2068-1-michael.d.kinney@intel.com> <016201d55c44$e42cf220$ac86d660$@insyde.com> <734D49CCEBEEF84792F5B80ED585239D5C29AF21@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjE4ZjRmMmItZmY1Mi00NjQwLWJlZTItMzZkOGU5MjAzZGY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV0ttTlwveUhvT3BYM1ZPRnFmUWJEcjZiM2Y5MnNmXC9mV2pldHdtSmdOeGtVMmpLWGhqdVh4aGlYQmpPelF4SFp2In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable pushed @ abc0155b03..30b4abc6e9. > -----Original Message----- > From: afish@apple.com > Sent: Monday, August 26, 2019 2:10 PM > To: Kinney, Michael D > Cc: Ni, Ray ; devel@edk2.groups.io; tim.lewis@insyde.c= om; leif.lindholm@linaro.org; Justen, Jordan L > > Subject: Re: [edk2-devel] [Patch][edk2-stable201908 0/2] EmulatorPkg/Win= /Host: Fix image unload regression >=20 > Mike, >=20 > I'm OK with it going in. >=20 > Thanks, >=20 > Andrew Fish >=20 > > On Aug 26, 2019, at 2:01 PM, Kinney, Michael D wrote: > > > > Ray, > > > > Laszlo and I are OK with this change going into the stable tag. > > > > I would like to a response from Andrew or Leif. > > > > Mike > > > >> -----Original Message----- > >> From: Ni, Ray > >> Sent: Monday, August 26, 2019 1:35 PM > >> To: devel@edk2.groups.io; tim.lewis@insyde.com; Kinney, > >> Michael D > >> Cc: Justen, Jordan L ; > >> 'Andrew Fish' > >> Subject: RE: [edk2-devel] [Patch][edk2-stable201908 0/2] > >> EmulatorPkg/Win/Host: Fix image unload regression > >> > >> All, > >> As the package maintainer of EmulatorPkg, I should push > >> the patches. > >> But I am not sure if there should be some ack from > >> stewards regarding including this patch in the coming > >> stable tag. > >> > >> What's the process? > >> > >> Thanks, > >> Ray > >> > >>> -----Original Message----- > >>> From: devel@edk2.groups.io On > >> Behalf Of Tim > >>> Lewis > >>> Sent: Monday, August 26, 2019 12:32 PM > >>> To: Kinney, Michael D ; > >>> devel@edk2.groups.io > >>> Cc: Justen, Jordan L ; Ni, > >> Ray > >>> ; 'Andrew Fish' > >>> Subject: Re: [edk2-devel] [Patch][edk2-stable201908 > >> 0/2] > >>> EmulatorPkg/Win/Host: Fix image unload regression > >>> > >>> Tested-by: Tim Lewis > >>> > >>> -----Original Message----- > >>> From: Michael D Kinney > >>> Sent: Wednesday, August 21, 2019 7:36 PM > >>> To: devel@edk2.groups.io > >>> Cc: Jordan Justen ; Ray Ni > >>> ; Andrew Fish ; Tim > >> Lewis > >>> > >>> Subject: [Patch][edk2-stable201908 0/2] > >> EmulatorPkg/Win/Host: Fix > >>> image unload regression > >>> > >>> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2104 > >>> > >>> When UEFI Applications or UEFI Drivers are unloaded, > >> the > >>> PeCoffLoaderUnloadImageExtraAction() needs to unload > >> the image using > >>> FreeLibrary() if the image was successfully loaded > >> using LoadLibrrayEx(). > >>> > >>> This is a regression from the Nt32Pkg that supported > >> unloading > >>> applications and drivers as well as loading the same > >> application or > >>> driver multiple times. > >>> > >>> Cc: Jordan Justen > >>> Cc: Ray Ni > >>> Cc: Andrew Fish > >>> Cc: Tim Lewis > >>> Signed-off-by: Michael D Kinney > >> > >>> > >>> Michael D Kinney (2): > >>> EmulatorPkg/Win/Host: Fix image unload regression > >>> EmulatorPkg/Win/Host: Fix SecPrint() log line > >> endings > >>> > >>> EmulatorPkg/Win/Host/WinHost.c | 193 > >>> +++++++++++++++++++++++++++++---- > >>> 1 file changed, 174 insertions(+), 19 deletions(-) > >>> > >>> -- > >>> 2.21.0.windows.1 > >>> > >>> > >>> > >>>=20 > >