From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Mon, 26 Aug 2019 17:45:58 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Aug 2019 17:45:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,435,1559545200"; d="scan'208";a="181541264" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 26 Aug 2019 17:45:57 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 17:45:57 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 26 Aug 2019 17:45:56 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Tue, 27 Aug 2019 08:45:54 +0800 From: "Ni, Ray" To: "Kinney, Michael D" , "Gao, Liming" , "devel@edk2.groups.io" CC: "afish@apple.com" , "leif.lindholm@linaro.org" , "Laszlo Ersek (lersek@redhat.com)" Subject: Re: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList Thread-Topic: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList Thread-Index: AQHVXDp+NF2kY0e/RUKW8I4anvfXM6cNvMcQ///YagCAAAakAIAAjM7A Date: Tue, 27 Aug 2019 00:45:54 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C29CEF9@SHSMSX104.ccr.corp.intel.com> References: <15BE8BCCADEA547C.18314@groups.io> <734D49CCEBEEF84792F5B80ED585239D5C29AD17@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC923@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDEzYWY5NjgtZDQ3Mi00MmI5LTlmY2ItYmNjYzc2ZmRhYzcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS2M5UTN4ZW4zOWlabFwvYTV6NSsxVnVvZk4xZm1SeVVYWVM4alhMZFFid1ZKcW90VENsVFByVnBac2hNVERMejQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The consumers are in close source and won't be in open source in near futur= e. But consumers depend on open source repo. > -----Original Message----- > From: Kinney, Michael D > Sent: Monday, August 26, 2019 5:20 PM > To: Gao, Liming ; Ni, Ray ; deve= l@edk2.groups.io; Kinney, Michael D > > Cc: afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek (lersek@redh= at.com) > Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLe= Config.h: Add type > EfiBluetoothSmpPeerAddressList >=20 > Ray, >=20 > Are there any components that need these new enum values? >=20 > The patch looks very straightforward and is from the > UEFI Spec, so I think the risk is low. But if consumers > will not show up until after the stable tag, perhaps this > should be one of the first patches after the stable tag. >=20 > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Monday, August 26, 2019 4:57 PM > > To: Ni, Ray ; devel@edk2.groups.io > > Cc: Kinney, Michael D ; > > afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek > > (lersek@redhat.com) > > Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] > > MdePkg/BluetoothLeConfig.h: Add type > > EfiBluetoothSmpPeerAddressList > > > > Cc to all Stewards. > > > > >-----Original Message----- > > >From: Ni, Ray > > >Sent: Tuesday, August 27, 2019 2:20 AM > > >To: devel@edk2.groups.io; Ni, Ray > > >Cc: Kinney, Michael D ; > > Gao, Liming > > > > > >Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] > > >MdePkg/BluetoothLeConfig.h: Add type > > EfiBluetoothSmpPeerAddressList > > > > > >I understand it's now in code freeze phase. > > >Just make a try to see whether this very clean/simple > > header file > > >change can be included in the stable tag. > > >Any platform that uses BLE stack can get benefit from > > this definition update. > > > > > >> -----Original Message----- > > >> From: devel@edk2.groups.io On > > Behalf Of Ni, > > >> Ray > > >> Sent: Monday, August 26, 2019 11:16 AM > > >> To: devel@edk2.groups.io > > >> Cc: Kinney, Michael D ; > > Gao, Liming > > > > > >> Subject: [edk2-devel] [PATCH] [edk2-stable201908] > > >MdePkg/BluetoothLeConfig.h: Add type > > EfiBluetoothSmpPeerAddressList > > >> > > >> To support auto-connection, > > EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs > > >to > > >> add a new data type EfiBluetoothSmpPeerAddressList > > which associates > > >> with a list of Bluetooth per address connected > > before. > > >> > > >> This new data type was added in UEFI spec 2.7b. > > >> > > >> Signed-off-by: Ray Ni > > >> Cc: Michael D Kinney > > >> Cc: Liming Gao > > >> --- > > >> MdePkg/Include/Protocol/BluetoothLeConfig.h | 4 +++- > > >> 1 file changed, 3 insertions(+), 1 deletion(-) > > >> > > >> diff --git > > a/MdePkg/Include/Protocol/BluetoothLeConfig.h > > >b/MdePkg/Include/Protocol/BluetoothLeConfig.h > > >> index 8c0f881f85..8726a58b15 100644 > > >> --- a/MdePkg/Include/Protocol/BluetoothLeConfig.h > > >> +++ b/MdePkg/Include/Protocol/BluetoothLeConfig.h > > >> @@ -2,7 +2,7 @@ > > >> EFI Bluetooth LE Config Protocol as defined in > > UEFI 2.7. > > >> This protocol abstracts user interface > > configuration for BluetoothLe device. > > >> > > >> - Copyright (c) 2017, Intel Corporation. All rights > > reserved.
> > >> + Copyright (c) 2017 - 2019, Intel Corporation. All > > rights > > >> + reserved.
> > >> SPDX-License-Identifier: BSD-2-Clause-Patent > > >> > > >> @par Revision Reference: > > >> @@ -451,6 +451,8 @@ typedef enum { > > >> EfiBluetoothSmpLocalCSRK, /* If Key hierarchy not > > supported */ > > >> EfiBluetoothSmpLocalSignCounter, > > >> EfiBluetoothSmpLocalDIV, > > >> + EfiBluetoothSmpPeerAddressList, > > >> + EfiBluetoothSmpMax, > > >> } EFI_BLUETOOTH_LE_SMP_DATA_TYPE; > > >> > > >> /** > > >> -- > > >> 2.21.0.windows.1 > > >> > > >> > > >>=20