From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 28 Aug 2019 10:33:33 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2019 10:33:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,441,1559545200"; d="scan'208,217";a="192669421" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 28 Aug 2019 10:33:32 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 28 Aug 2019 10:33:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.163]) with mapi id 14.03.0439.000; Thu, 29 Aug 2019 01:33:29 +0800 From: "Ni, Ray" To: "Gao, Liming" , "Cetola, Stephano" , "Kinney, Michael D" , "leif.lindholm@linaro.org" , "Jayanth.Raghuram@dell.com" , "'Andrew Fish (afish@apple.com)'" , Laszlo Ersek CC: "Wei.G.Liu@dell.com" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Topic: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Thread-Index: AdVcR+OPrxJmOcouRhWzA1r7t1m4TQAMoO6AACKbwDAAHEv/sAAT9+pw Date: Wed, 28 Aug 2019 17:33:28 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2A1B73@SHSMSX104.ccr.corp.intel.com> References: <31e5cee5c49d4381bfb26a0968c11749@ausx13mps324.AMER.DELL.COM> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9B@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DD7DA@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DD7DA@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODhjNzQzZjAtY2VkYS00MGVhLTk1ZjUtMWJjYjdkMzExN2YyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUjgwQjNyaytrelQ2ME5rXC9EekVjcWVmVXZKelZhOENRT0xzWGVIZ1ZVcWg4S2QrM3Y2Z2JEVm5hN3paZWxYTXIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_734D49CCEBEEF84792F5B80ED585239D5C2A1B73SHSMSX104ccrcor_" --_000_734D49CCEBEEF84792F5B80ED585239D5C2A1B73SHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, Stephano and all stewards, My understanding is the requirement of embedding patch into the mail body = is due to a limitation in old system (01.org). That system couldn't support= mail attachments. With the existence of mail attachments capability in new groups.io system,= can we accept such kind of patch submission? Or any side effect you see if= allowing mail attachments? Thanks, Ray From: devel@edk2.groups.io On Behalf Of Liming Gao Sent: Wednesday, August 28, 2019 12:59 AM To: Jayanth.Raghuram@dell.com; devel@edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to impro= ve error handling. OK. So, you can't use git send-email to send this patch. Another way is to= fork edk2 and create the branch to include this change. Then, send the mail to let people review this patch in your branch. And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ fir= st? Then, update its commit message format based on this wiki. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Forma= t Thanks Liming From: Jayanth.Raghuram@dell.com [mailto:= Jayanth.Raghuram@dell.com] Sent: Wednesday, August 28, 2019 2:30 AM To: Gao, Liming >; devel= @edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error hand= ling. Hi Liming, I sent the review request based on the description in the links that you m= entioned below. I sent it in an Dell Email since I cannot use GIT SMTP to send email out f= rom our servers. Please let me know what is wrong and I can help rectify that. Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 From: Gao, Liming > Sent: Monday, August 26, 2019 8:57 PM To: devel@edk2.groups.io; Raghuram, Jayanth Cc: Liu, Wei G Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error hand= ling. [EXTERNAL EMAIL] Can you follow this process to send this patch again? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-P= rocess And, the commit message format is https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Forma= t Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2= .groups.io] On Behalf Of Jayanth.Raghuram@dell.com Sent: Tuesday, August 27, 2019 3:55 AM To: devel@edk2.groups.io Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve e= rror handling. Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling= . Added checks for return parameters of LocateHandleBuffer & GetSupportedTyp= es function calls in InternalHstiFindAip to improve error handling. An issue = was observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI driver returned InfoTypesBuffer =3D NULL, InfoTypesBufferCount =3D 0 and c= aused an FreePool assert. Signed-off-by: Jayanth Raghuram > Cc: Wei G Liu > Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch Regards Jayanth Raghuram DellEMC | Server Platform BIOS office + 1 512 723 1470 --_000_734D49CCEBEEF84792F5B80ED585239D5C2A1B73SHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Liming, Stephano and all stewards,

My understanding is the requirement of embedding pa= tch into the mail body is due to a limitation in old system (01.org). That = system couldn’t support mail attachments.

 

With the existence of mail attachments capability i= n new groups.io system, can we accept such kind of patch submission? Or any= side effect you see if allowing mail attachments?

 

Thanks,

Ray

 

From: de= vel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Liming Gao
Sent: Wednesday, August 28, 2019 12:59 AM
To: Jayanth.Raghuram@dell.com; devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com
Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks t= o improve error handling.

 

OK. So, you can’= ;t use git send-email to send this patch. Another way is to fork edk2 and c= reate the branch to include this change.

Then, send the mail t= o let people review this patch in your branch.

 

And, for this patch, = can you submit BZ https://bugzilla.tianoc= ore.org/ first?

Then, update its comm= it message format based on this wiki.

https://github.com/tianocore/tianocore= .github.io/wiki/Commit-Message-Format

 

Thanks

Liming

From: Jayanth.Raghuram@dell.com [mailto:Jayanth.Raghuram@dell.com]
Sent: Wednesday, August 28, 2019 2:30 AM
To: Gao, Liming <liming.= gao@intel.com>; devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve err= or handling.

 

Hi Liming,

 

I sent the review request based on the description = in the links that you mentioned below.

I sent it in an Dell Email since I cannot use GIT S= MTP to send email out from our servers.

Please let me know what is wrong and I can help rec= tify that.

 

Regards

Jayanth Raghuram=

DellEMC | Server Platform BIOS

office + 1 512 723 1470

 

 

[EXTERNAL EMAIL]

Can you follow this p= rocess to send this patch again?

https://github.com/tianocore/tian= ocore.github.io/wiki/EDK-II-Development-Process

 

And, the commit messa= ge format is

https://github.com/tianocore/tianocore= .github.io/wiki/Commit-Message-Format

 

Thanks

Liming

From: devel@edk2.groups.io [mailto:= devel@edk2.groups.io] On Behalf Of Jayanth.R= aghuram@dell.com
Sent: Tuesday, August 27, 2019 3:55 AM
To: devel@edk2.groups.io
Cc: Wei.G.Liu@dell.com Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to im= prove error handling.

 

Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to= improve error handling.

Added checks for return parameters of LocateHandleB= uffer & GetSupportedTypes

function calls in InternalHstiFindAip to improve er= ror handling. An issue was

observed on Dell Poweredge R740, where the Dell PER= C H740P controller UEFI

driver returned InfoTypesBuffer =3D NULL, InfoTypes= BufferCount =3D 0 and caused

an FreePool assert.

 

Signed-off-by: Jayanth Raghuram <Jayanth.Raghuram@Dell.com><= /p>

Cc: Wei G Liu <Wei_G_Liu@Dell.com>

 

Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-im= prove-error-hand.patch

 

Regards

Jayanth Raghuram=

DellEMC | Server Platform BIOS

office + 1 512 723 1470

 

--_000_734D49CCEBEEF84792F5B80ED585239D5C2A1B73SHSMSX104ccrcor_--