Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

["Ni, Ray" <ray.ni@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Thursday, August 29, 2019 7:24 AM
> To: Leif Lindholm <leif.lindholm@linaro.org>; Ni, Ray <ray.ni@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>; Cetola, Stephano <stephano.cetola@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Jayanth.Raghuram@dell.com; 'Andrew Fish (afish@apple.com)' <afish@apple.com>;
> Wei.G.Liu@dell.com; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.
> 
> On 08/29/19 11:49, Leif Lindholm wrote:
> > On Wed, Aug 28, 2019 at 05:33:28PM +0000, Ni, Ray wrote:
> 
> >> With the existence of mail attachments capability in new groups.io
> >> system, can we accept such kind of patch submission? Or any side
> >> effect you see if allowing mail attachments?
> >
> > Traditionally, the reason for not wanting patches as attachments is
> > that it complicates doing inline code review as part of the email.
> >
> > If the mail system (let's take a wild guess, Outlook/Exchange?)
> > doesn't corrupt the text *too* badly, I don't have an issue with the
> > patch being sent in the message body *and* being attached so it could
> > actually be applied.

Leif,
So, message body should have the patch changes for easy inline review. It's optional to carry a .diff attachment.
Is my understanding correct?

> 
> - Doesn't work for patch series, only for single patches.
Laszlo,
Do you mean attachment is not allowed for a series of patch? Why? A mail can carry multiple attachments. That makes the patch series easy to fetch in my opinion from Outlook.