From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 03 Sep 2019 21:10:01 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2019 21:10:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,465,1559545200"; d="scan'208";a="382357870" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 03 Sep 2019 21:10:00 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 21:10:00 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 21:10:00 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.146]) with mapi id 14.03.0439.000; Wed, 4 Sep 2019 12:09:58 +0800 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: Oleksiy , "Gao, Liming" Subject: Re: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to PCI5.0 Thread-Topic: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to PCI5.0 Thread-Index: AQHVYNgFaCDJtaVEu0O1Rs+g1T3FVKca6zOA Date: Wed, 4 Sep 2019 04:09:57 +0000 Deferred-Delivery: Wed, 4 Sep 2019 04:09:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2BFDC0@SHSMSX104.ccr.corp.intel.com> References: <20190901151443.11568-1-zhichao.gao@intel.com> In-Reply-To: <20190901151443.11568-1-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjA0NjJmOTktMDhjNi00MTQyLWIyYzItMzM4NjE1ODc5OGE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQTkwQzFycGpiVTBzdU9QNXZ4c1JlcVhWS1VZd09yNElDYmhVYzQ3aEdsQXQxMUx1bVZsRXpiWno4Njh6UDdqMyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Gao, Zhichao > Sent: Sunday, September 1, 2019 8:15 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray ; Ole= ksiy ; Gao, Liming > > Subject: [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to PC= I5.0 >=20 > From: "Gao, Zhichao" >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1955 >=20 > Refer to PCI express base specification Reversion 5.0, Version > 1.0, Table 7-33, Supported Link Speeds Vector bit 3 indicate > the speed 16 GT/s and bit 4 indicate the speed 32 GT/s. > Add the support to shell command 'pci ...'. >=20 > Change the MaxLinkSpeed other values' result from 'Unknown' > to 'Reserved' to make the result align. >=20 > Cc: Ray Ni > Cc: Oleksiy > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > V2: > Update the copyright. >=20 > V3: > Update the link speed to support PCI 5.0. >=20 > Update the support > .../Library/UefiShellDebug1CommandsLib/Pci.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c b/ShellPkg= /Library/UefiShellDebug1CommandsLib/Pci.c > index ba9caa774398..3e138188cec3 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > @@ -1,7 +1,7 @@ > /** @file > Main file for Pci shell Debug1 function. >=20 > - Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2005 - 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -4515,8 +4515,14 @@ ExplainPcieLinkCap ( > case 3: > MaxLinkSpeed =3D L"8.0 GT/s"; > break; > + case 4: > + MaxLinkSpeed =3D L"16.0 GT/s"; > + break; > + case 5: > + MaxLinkSpeed =3D L"32.0 GT/s"; > + break; > default: > - MaxLinkSpeed =3D L"Unknown"; > + MaxLinkSpeed =3D L"Reserved"; > break; > } > ShellPrintEx (-1, -1, > @@ -4672,6 +4678,12 @@ ExplainPcieLinkStatus ( > case 3: > CurLinkSpeed =3D L"8.0 GT/s"; > break; > + case 4: > + CurLinkSpeed =3D L"16.0 GT/s"; > + break; > + case 5: > + CurLinkSpeed =3D L"32.0 GT/s"; > + break; > default: > CurLinkSpeed =3D L"Reserved"; > break; > -- > 2.21.0.windows.1