From: "Ni, Ray" <ray.ni@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>
Cc: Gris87 <Gris87@yandex.ru>, "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [PATCH] MdeModulePkg: Add missing sourceX for Blt
Date: Mon, 16 Sep 2019 20:57:04 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2E1CC7@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <583ec11aa07d5f93113237da627d058c5672c322.1568643322.git.Gris87@yandex.ru>
+ Zhichao for review.
> -----Original Message-----
> From: Gris87 <Gris87@yandex.ru>
> Sent: Monday, September 16, 2019 7:22 AM
> To: devel@edk2.groups.io
> Cc: Gris87 <Gris87@yandex.ru>; Ni, Ray <ray.ni@intel.com>
> Subject: [PATCH] MdeModulePkg: Add missing sourceX for Blt
>
> There is no sourceX offset in case when
> Configure->PixelFormat == PixelBlueGreenRedReserved8BitPerColor.
> We are copying most left pixels instead of copying required rectangle.
>
> Signed-off-by: Gris87 <Gris87@yandex.ru>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> ---
> MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c
> b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c
> index 47c5326e99..ff7979c962 100644
> --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c
> +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c
> @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo (
> Destination = Configure->FrameBuffer + Offset;
>
> if (Configure->PixelFormat == PixelBlueGreenRedReserved8BitPerColor) {
> - Source = (UINT8 *) BltBuffer + (SrcY * Delta);
> + Source = (UINT8 *) BltBuffer + (SrcY * Delta) + SourceX * sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL);
> } else {
> for (IndexX = 0; IndexX < Width; IndexX++) {
> Blt =
> --
> 2.19.1
next prev parent reply other threads:[~2019-09-16 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 14:21 [PATCH] MdeModulePkg: Add missing sourceX for Blt Gris87
2019-09-16 20:57 ` Ni, Ray [this message]
2019-09-17 6:59 ` Gao, Zhichao
2019-09-25 4:44 ` [edk2-devel] " Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C2E1CC7@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox