From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Mon, 16 Sep 2019 13:57:14 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 13:57:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,514,1559545200"; d="scan'208";a="180559728" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 16 Sep 2019 13:57:07 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 13:57:06 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 13:57:06 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.53]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 04:57:04 +0800 From: "Ni, Ray" To: "Gao, Zhichao" CC: Gris87 , "devel@edk2.groups.io" Subject: Re: [PATCH] MdeModulePkg: Add missing sourceX for Blt Thread-Topic: [PATCH] MdeModulePkg: Add missing sourceX for Blt Thread-Index: AQHVbJofowge1e/1YUCr1HZrKHmESacuyVGA Date: Mon, 16 Sep 2019 20:57:04 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2E1CC7@SHSMSX104.ccr.corp.intel.com> References: <583ec11aa07d5f93113237da627d058c5672c322.1568643322.git.Gris87@yandex.ru> In-Reply-To: <583ec11aa07d5f93113237da627d058c5672c322.1568643322.git.Gris87@yandex.ru> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTVkMDZiOTEtOWNlZC00NWVhLTk0MGYtZjFjNGY1ODU0YWNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU3hqZ3FiSVB6QzhBME5MdVNIM2FoMkFuaGdBVDFtcnlRWlNSZ3BDQUVQSmdZSzJGelpZbTNKanZ5REZMdmpoOSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable + Zhichao for review. > -----Original Message----- > From: Gris87 > Sent: Monday, September 16, 2019 7:22 AM > To: devel@edk2.groups.io > Cc: Gris87 ; Ni, Ray > Subject: [PATCH] MdeModulePkg: Add missing sourceX for Blt >=20 > There is no sourceX offset in case when > Configure->PixelFormat =3D=3D PixelBlueGreenRedReserved8BitPerColor. > We are copying most left pixels instead of copying required rectangle. >=20 > Signed-off-by: Gris87 > Cc: Ruiyu Ni > --- > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > index 47c5326e99..ff7979c962 100644 > --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo ( > Destination =3D Configure->FrameBuffer + Offset; >=20 > if (Configure->PixelFormat =3D=3D PixelBlueGreenRedReserved8BitPerCo= lor) { > - Source =3D (UINT8 *) BltBuffer + (SrcY * Delta); > + Source =3D (UINT8 *) BltBuffer + (SrcY * Delta) + SourceX * sizeof= (EFI_GRAPHICS_OUTPUT_BLT_PIXEL); > } else { > for (IndexX =3D 0; IndexX < Width; IndexX++) { > Blt =3D > -- > 2.19.1