From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Tue, 17 Sep 2019 13:01:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 13:01:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,517,1559545200"; d="scan'208";a="198804540" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 17 Sep 2019 13:01:11 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 13:01:11 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 13:01:11 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.140]) with mapi id 14.03.0439.000; Wed, 18 Sep 2019 04:01:09 +0800 From: "Ni, Ray" To: Laszlo Ersek , edk2-devel-groups-io CC: Andrew Fish , "Justen, Jordan L" Subject: Re: [PATCH 06/35] EmulatorPkg: stop abusing EFI_HANDLE for keystroke notify registration Thread-Topic: [PATCH 06/35] EmulatorPkg: stop abusing EFI_HANDLE for keystroke notify registration Thread-Index: AQHVbZEeoTKnjO1Qf0OxwSTi2JxwZKcwShmw Date: Tue, 17 Sep 2019 20:01:08 +0000 Deferred-Delivery: Tue, 17 Sep 2019 20:01:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2E3B74@SHSMSX104.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-7-lersek@redhat.com> In-Reply-To: <20190917194935.24322-7-lersek@redhat.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTVhMjY1ZjgtZmFkZi00YjgzLTk2OTYtODhjY2YxNDg1N2MwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVHNTb2RjMWxseGNCcnJSYWRTZWppNUJTdHRiUTVGRk12eEY3ekFlNmtKaFBESE4xRTk3c2haXC9vZFJPTmNLOXEifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Laszlo Ersek > Sent: Tuesday, September 17, 2019 12:49 PM > To: edk2-devel-groups-io > Cc: Andrew Fish ; Justen, Jordan L ; Ni, Ray > Subject: [PATCH 06/35] EmulatorPkg: stop abusing EFI_HANDLE for keystroke= notify registration >=20 > EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require > the notification handle to have type (VOID*). The notification handle has > nothing to do with the EFI_HANDLE type. >=20 > This change is a semantic fix; functionally, it's a no-op. >=20 > Cc: Andrew Fish > Cc: Jordan Justen > Cc: Ray Ni > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > build-tested only >=20 > EmulatorPkg/EmuGopDxe/GopInput.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/EmulatorPkg/EmuGopDxe/GopInput.c b/EmulatorPkg/EmuGopDxe/Gop= Input.c > index fdd0b4911555..2a23564a2173 100644 > --- a/EmulatorPkg/EmuGopDxe/GopInput.c > +++ b/EmulatorPkg/EmuGopDxe/GopInput.c > @@ -517,7 +517,7 @@ EmuGopSimpleTextInExRegisterKeyNotify ( > IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, > IN EFI_KEY_DATA *KeyData, > IN EFI_KEY_NOTIFY_FUNCTION KeyNotificationFunction, > - OUT EFI_HANDLE *NotifyHandle > + OUT VOID **NotifyHandle > ) > { > EFI_STATUS Status; > @@ -600,7 +600,7 @@ EFI_STATUS > EFIAPI > EmuGopSimpleTextInExUnregisterKeyNotify ( > IN EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL *This, > - IN EFI_HANDLE NotificationHandle > + IN VOID *NotificationHandle > ) > /*++ >=20 > -- > 2.19.1.3.g30247aa5d201 >=20