From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Tue, 17 Sep 2019 13:02:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 13:02:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,517,1559545200"; d="scan'208";a="338101294" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 17 Sep 2019 13:02:11 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 13:02:10 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 13:02:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0439.000; Wed, 18 Sep 2019 04:02:08 +0800 From: "Ni, Ray" To: Laszlo Ersek , edk2-devel-groups-io CC: Andrew Fish , "Justen, Jordan L" Subject: Re: [PATCH 05/35] EmulatorPkg/DxeTimerLib: drop superfluous cast Thread-Topic: [PATCH 05/35] EmulatorPkg/DxeTimerLib: drop superfluous cast Thread-Index: AQHVbZEZSX0z88d1c0W/xk5tR4T/7qcwSiUQ Date: Tue, 17 Sep 2019 20:02:08 +0000 Deferred-Delivery: Tue, 17 Sep 2019 20:02:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2E3B91@SHSMSX104.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-6-lersek@redhat.com> In-Reply-To: <20190917194935.24322-6-lersek@redhat.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODNiZmZlNzEtMDU1ZS00OTE1LWIyOTctY2RkNGMxYzQ4NGFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ1JHUEZuUGJMQlVRdTlIZldGeEwzVjUzOXEyRUptMVJMeTJlUmF2WXlJQkgwN1M1UHFqZVltZ3dPYUp4TWduTyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Laszlo Ersek > Sent: Tuesday, September 17, 2019 12:49 PM > To: edk2-devel-groups-io > Cc: Andrew Fish ; Justen, Jordan L ; Ni, Ray > Subject: [PATCH 05/35] EmulatorPkg/DxeTimerLib: drop superfluous cast >=20 > "gTimerEvent" has type EFI_EVENT already, drop the superfluous cast. >=20 > Cc: Andrew Fish > Cc: Jordan Justen > Cc: Ray Ni > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > build-tested only >=20 > EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c b/EmulatorPkg/= Library/DxeTimerLib/DxeTimerLib.c > index 14cae4214c66..6fb5d8f3aaea 100644 > --- a/EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c > +++ b/EmulatorPkg/Library/DxeTimerLib/DxeTimerLib.c > @@ -40,7 +40,7 @@ RegisterTimerArchProtocol ( > gTimerPeriod =3D MultU64x32 (gTimerPeriod, 100); >=20 > if (gTimerEvent =3D=3D NULL) { > - Status =3D gBS->CreateEvent (EVT_TIMER, 0, NULL, NULL, (VOID **)&g= TimerEvent); > + Status =3D gBS->CreateEvent (EVT_TIMER, 0, NULL, NULL, &gTimerEven= t); > ASSERT_EFI_ERROR (Status); > } > } > -- > 2.19.1.3.g30247aa5d201 >=20