From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Tue, 17 Sep 2019 13:16:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 13:16:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,518,1559545200"; d="scan'208";a="387683783" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 17 Sep 2019 13:16:11 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 13:16:11 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Sep 2019 13:16:11 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.132]) with mapi id 14.03.0439.000; Wed, 18 Sep 2019 04:16:09 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Bi, Dandan" , "Dong, Eric" , "Wu, Hao A" , "Wang, Jian J" , "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for keystroke notify registration Thread-Topic: [edk2-devel] [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for keystroke notify registration Thread-Index: AQHVbZEjAk9foTC5o0WiBh0G7xYLw6cwTiiw Date: Tue, 17 Sep 2019 20:16:09 +0000 Deferred-Delivery: Tue, 17 Sep 2019 20:16:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2E3D1A@SHSMSX104.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-13-lersek@redhat.com> In-Reply-To: <20190917194935.24322-13-lersek@redhat.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2MwMDU0Y2MtODk2Ny00Yzg5LTk5NTctMDVhYjFmYThlYzE3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaWZMemRuZDh3andhNDJqNzJHVldJS2dlUThXV2hRZUNGZlBucTNpU2NyTFdKOUhYNm9ZWFJnRTc3WUVaMW1mbCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Laszlo Ers= ek > Sent: Tuesday, September 17, 2019 12:49 PM > To: edk2-devel-groups-io > Cc: Bi, Dandan ; Dong, Eric ; W= u, Hao A ; Wang, Jian J > ; Ni, Ray ; Gao, Zhichao > Subject: [edk2-devel] [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE= for keystroke notify registration >=20 > EFI_REGISTER_KEYSTROKE_NOTIFY and EFI_UNREGISTER_KEYSTROKE_NOTIFY require > the notification handle to have type (VOID*). The notification handle has > nothing to do with the EFI_HANDLE type. >=20 > This change is a semantic fix; functionally, it's a no-op. >=20 > Cc: Dandan Bi > Cc: Eric Dong > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > lightly tested: ConSplitterDxe is part of the ArmVirt and OVMF platfo= rms >=20 > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- > MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > index 63c814ae1816..9c38271b65f9 100644 > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > @@ -4026,7 +4026,7 @@ ConSplitterTextInRegisterKeyNotify ( > if (NewNotify =3D=3D NULL) { > return EFI_OUT_OF_RESOURCES; > } > - NewNotify->NotifyHandleList =3D (EFI_HANDLE *) AllocateZeroPool (sizeo= f (EFI_HANDLE) * Private->TextInExListCount); > + NewNotify->NotifyHandleList =3D (VOID **) AllocateZeroPool (sizeof (VO= ID *) * Private->TextInExListCount); > if (NewNotify->NotifyHandleList =3D=3D NULL) { > gBS->FreePool (NewNotify); > return EFI_OUT_OF_RESOURCES; > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > index 7cfd5c178861..f98797225b63 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > +++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > @@ -143,7 +143,7 @@ InternalStartMonitor( > EFI_HANDLE *Handles; > UINTN HandleCount; > UINTN HandleIndex; > - EFI_HANDLE NotifyHandle; > + VOID *NotifyHandle; >=20 > Status =3D gBS->LocateHandleBuffer ( > ByProtocol, > @@ -202,7 +202,7 @@ InternalStopMonitor( > EFI_KEY_DATA KeyData; > UINTN HandleCount; > UINTN HandleIndex; > - EFI_HANDLE NotifyHandle; > + VOID *NotifyHandle; >=20 > Status =3D gBS->LocateHandleBuffer ( > ByProtocol, > -- > 2.19.1.3.g30247aa5d201 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#47399): https://edk2.groups.io/g/devel/message/47399 > Mute This Topic: https://groups.io/mt/34180213/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D