From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Thu, 26 Sep 2019 18:12:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 18:12:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,553,1559545200"; d="scan'208";a="201848178" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 26 Sep 2019 18:12:17 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 18:12:17 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 18:12:16 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0439.000; Fri, 27 Sep 2019 09:12:15 +0800 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" , "Gao, Liming" Subject: Re: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support Thread-Topic: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support Thread-Index: AQHVdNAbHJgkjL8mIUaj2x8Z34I/cKc+t4bA Date: Fri, 27 Sep 2019 01:12:14 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C2F3E9C@SHSMSX104.ccr.corp.intel.com> References: <20190927010831.25944-1-zhichao.gao@intel.com> In-Reply-To: <20190927010831.25944-1-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjgyYWU5OGItYmU0OS00YjE3LWI1MDktMTllMDA0NGNiNGZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibFpiZW9yc3hLN3lySVZTdDNqWHhmZWl4Q2xwcTcwVXp0OU9VZ3VndEtQMW9wem10N01iMHRndStIVTV4WWpsNiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, September 26, 2019 6:09 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ;= Ni, Ray ; Gao, Liming > > Subject: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys supp= ort >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2219 >=20 > First previous patch remove the VT100Plus's arrow keys' support. > Add it back. >=20 > The arrow keys would send ESC [A through to ESC [D. Add this > support for the new introduced terminal type. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Ray Ni > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > .../Universal/Console/TerminalDxe/TerminalConIn.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > index ac31f27984..f8c71f95c1 100644 > --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > @@ -1670,8 +1670,12 @@ UnicodeToEfiKey ( >=20 > if (TerminalDevice->TerminalType =3D=3D TerminalTypePcAnsi || > TerminalDevice->TerminalType =3D=3D TerminalTypeVt100 || > - TerminalDevice->TerminalType =3D=3D TerminalTypeVtUtf8 || > - TerminalDevice->TerminalType =3D=3D TerminalTypeTtyTerm || > + TerminalDevice->TerminalType =3D=3D TerminalTypeVt100Plus || > + TerminalDevice->TerminalType =3D=3D TerminalTypeVtUtf8 || > + TerminalDevice->TerminalType =3D=3D TerminalTypeTtyTerm || > + TerminalDevice->TerminalType =3D=3D TerminalTypeLinux || > + TerminalDevice->TerminalType =3D=3D TerminalTypeXtermR6 || > + TerminalDevice->TerminalType =3D=3D TerminalTypeVt400 || > TerminalDevice->TerminalType =3D=3D TerminalTypeSCO) { > switch (UnicodeChar) { > case 'A': > -- > 2.21.0.windows.1