Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0

["Ni, Ray" <ray.ni@intel.com>]

Existing close source platform BDS only updates UI in this function.
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Pete Batard
> Sent: Wednesday, September 25, 2019 11:50 PM
> To: devel@edk2.groups.io
> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0
> 
> The existing loop is set to call PlatformBootManagerWaitCallback every
> second except the last one. We believe this is a mistake as it prevents
> the called code from performing timeout expiration tasks such as, for
> instance, ensuring that the last segment of a progress bar is displayed
> before continuing (which is a current issue for the RPi3 platform).
> 
> Signed-off-by: Pete Batard <pete@akeo.ie>
> ---
>  MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> index f3d5e5ac0615..7968a58f3454 100644
> --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> @@ -341,6 +341,7 @@ BdsWait (
>        TimeoutRemain--;
>      }
>    }
> +  PlatformBootManagerWaitCallback (0);
>    DEBUG ((EFI_D_INFO, "[Bds]Exit the waiting!\n"));
>  }
> 
> --
> 2.21.0.windows.1
> 
> 
>