From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Sun, 29 Sep 2019 18:24:58 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2019 18:24:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,565,1559545200"; d="scan'208";a="195171072" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 29 Sep 2019 18:24:57 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 18:24:57 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 29 Sep 2019 18:24:56 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 29 Sep 2019 18:24:56 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.165]) with mapi id 14.03.0439.000; Mon, 30 Sep 2019 09:24:55 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "pete@akeo.ie" CC: "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0 Thread-Topic: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call PlatformBootManagerWaitCallback on 0 Thread-Index: AQHVc7j1NHlsqSen70eQSlJYRGrSDadDc+cA Date: Mon, 30 Sep 2019 01:24:55 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C30A314@SHSMSX104.ccr.corp.intel.com> References: <20190925155005.12532-1-pete@akeo.ie> In-Reply-To: <20190925155005.12532-1-pete@akeo.ie> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGVkODg5YjQtNjUyMi00MzMxLWJmNTktMWMyYmE0ODg2MWZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVDVhMXZJZXhiZzdsS1gwaVJqMUNMdzVRdGhiOFl5M2p3NGxJVFhWNFB6WFZrVzFnVEtKVDdYTllCeHZLdXhoeCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Existing close source platform BDS only updates UI in this function. Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Pete Bata= rd > Sent: Wednesday, September 25, 2019 11:50 PM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray > Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg/BdsDxe: Also call Platfor= mBootManagerWaitCallback on 0 >=20 > The existing loop is set to call PlatformBootManagerWaitCallback every > second except the last one. We believe this is a mistake as it prevents > the called code from performing timeout expiration tasks such as, for > instance, ensuring that the last segment of a progress bar is displayed > before continuing (which is a current issue for the RPi3 platform). >=20 > Signed-off-by: Pete Batard > --- > MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Uni= versal/BdsDxe/BdsEntry.c > index f3d5e5ac0615..7968a58f3454 100644 > --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c > +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c > @@ -341,6 +341,7 @@ BdsWait ( > TimeoutRemain--; > } > } > + PlatformBootManagerWaitCallback (0); > DEBUG ((EFI_D_INFO, "[Bds]Exit the waiting!\n")); > } >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20