From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.2537.1571289676887752002 for ; Wed, 16 Oct 2019 22:21:17 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 22:21:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,306,1566889200"; d="scan'208";a="221009213" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 16 Oct 2019 22:21:16 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 16 Oct 2019 22:21:16 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 16 Oct 2019 22:21:16 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.33]) with mapi id 14.03.0439.000; Thu, 17 Oct 2019 13:21:14 +0800 From: "Ni, Ray" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "'Andrew Fish (afish@apple.com)'" Subject: Re: [edk2-devel] [Patch v2 10/11] EmulatorPkg: Enable CLANG9 tool chain Thread-Topic: [edk2-devel] [Patch v2 10/11] EmulatorPkg: Enable CLANG9 tool chain Thread-Index: AQHVgu9otZSXEoaHmkGDX6cIbp/ah6ddAUyAgACpkACAAKLUAA== Date: Thu, 17 Oct 2019 05:21:14 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C325901@SHSMSX104.ccr.corp.intel.com> References: <1571099210-12432-1-git-send-email-liming.gao@intel.com> <1571099210-12432-11-git-send-email-liming.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C32529F@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E51D6F1@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E51D6F1@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > > > >1. Why move the assignment to a later place? Can you explain a bit more? > The hang issue here. >=20 > I investigate this issue more. The root cause is that GetProcessAffinityM= ask() > API requires the 64bit pointer as the input for 64bit ARCH. So, the corre= ct fix > should declare ProcessAffinityMask and SystemAffinityMask as UINTN. I wil= l > update the patch. >=20 > (GetProcessAffinityMask (GetCurrentProcess (), &ProcessAffinityMask, > &SystemAffinityMask)) >=20 Thanks! > >2. If CLANG9 is used in Linux, WinHost is still used. That seems not goo= d. > > > Now, CLANG9 is for Windows Emulator only. The key problem is that there i= s > no way to know which OS is used in DSC. So for now, I will add the limita= tion > here. For long term, we need to think the way to support Emulator usage. >=20 It's nice to build correct OS-host module depending on compiler tool chain. But if CLANG9 is a cross-host compiler tool chain, I don't think such need = should be met. So I would prefer the patch doesn't assume CLANG9 is a hint to build Win ho= st. Which means when using CLANG9, developer needs to use another macro to tell build tool which host to build. > > > >3. Why TftpDynamicCommand cannot be built with CLANG9? > > > CLANG9 supports RC section. I will update patch to remove this change. Thanks.