From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.1267.1571622076929109001 for ; Sun, 20 Oct 2019 18:41:17 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2019 18:41:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,321,1566889200"; d="scan'208";a="227160332" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 20 Oct 2019 18:41:16 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 18:41:16 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 18:41:15 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by shsmsx102.ccr.corp.intel.com ([169.254.2.176]) with mapi id 14.03.0439.000; Mon, 21 Oct 2019 09:41:13 +0800 From: "Ni, Ray" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Sean Brogan Subject: Re: [Patch] FatPkg: Fix spelling errors Thread-Topic: [Patch] FatPkg: Fix spelling errors Thread-Index: AQHVhehlM0xJor2xnUKWJLOHL/IzHadkVOAA Date: Mon, 21 Oct 2019 01:41:12 +0000 Deferred-Delivery: Mon, 21 Oct 2019 01:40:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C329FFC@SHSMSX104.ccr.corp.intel.com> References: <20191018191513.4500-1-michael.d.kinney@intel.com> In-Reply-To: <20191018191513.4500-1-michael.d.kinney@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Kinney, Michael D > Sent: Saturday, October 19, 2019 3:15 AM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Ni, Ray > Subject: [Patch] FatPkg: Fix spelling errors >=20 > From: Sean Brogan >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2264 >=20 > Cc: Ray Ni > Signed-off-by: Michael D Kinney > --- > FatPkg/EnhancedFatDxe/DirectoryManage.c | 8 ++++---- > FatPkg/EnhancedFatDxe/DiskCache.c | 2 +- > FatPkg/EnhancedFatDxe/Fat.h | 20 ++++++++++---------- > FatPkg/EnhancedFatDxe/FileName.c | 2 +- > FatPkg/EnhancedFatDxe/FileSpace.c | 6 +++--- > FatPkg/EnhancedFatDxe/Info.c | 2 +- > FatPkg/EnhancedFatDxe/Init.c | 2 +- > FatPkg/EnhancedFatDxe/Misc.c | 6 +++--- > FatPkg/EnhancedFatDxe/Open.c | 2 +- > FatPkg/FatPei/FatLiteApi.c | 6 +++--- > FatPkg/FatPei/FatLitePeim.h | 4 ++-- > FatPkg/FatPei/Gpt.c | 2 +- > FatPkg/FatPei/Mbr.c | 2 +- > 13 files changed, 32 insertions(+), 32 deletions(-) >=20 > diff --git a/FatPkg/EnhancedFatDxe/DirectoryManage.c > b/FatPkg/EnhancedFatDxe/DirectoryManage.c > index 21656883bd..93772dba09 100644 > --- a/FatPkg/EnhancedFatDxe/DirectoryManage.c > +++ b/FatPkg/EnhancedFatDxe/DirectoryManage.c > @@ -17,7 +17,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > @param EntryPos - The position of the directory entry to= be > accessed. > @param Entry - The directory entry read or written. >=20 > - @retval EFI_SUCCESS - Access the directory entry sucessfully= . > + @retval EFI_SUCCESS - Access the directory entry successfull= y. > @return other - An error occurred when reading the dir= ectory entry. >=20 > **/ > @@ -896,7 +896,7 @@ FatNewEntryPos ( > @param Volume - FAT file system volume. > @param Name - The file name of the volume. >=20 > - @retval EFI_SUCCESS - Update the volume with the directory e= ntry > sucessfully. > + @retval EFI_SUCCESS - Update the volume with the directory e= ntry > successfully. > @return others - An error occurred when getting volume = label. >=20 > **/ > @@ -927,7 +927,7 @@ FatGetVolumeEntry ( > @param Volume - FAT file system volume. > @param Name - The new file name of the volume. >=20 > - @retval EFI_SUCCESS - Update the Volume sucessfully. > + @retval EFI_SUCCESS - Update the Volume successfully. > @retval EFI_UNSUPPORTED - The input label is not a valid volume la= bel. > @return other - An error occurred when setting volume la= bel. >=20 > @@ -1246,7 +1246,7 @@ FatCloseDirEnt ( > not be created either). > @retval EFI_INVALID_PARAMETER - The parameter is not valid. > @retval EFI_SUCCESS - Open the file successfully. > - @return other - An error occured when locating the OFi= le. > + @return other - An error occurred when locating the OF= ile. >=20 > **/ > EFI_STATUS > diff --git a/FatPkg/EnhancedFatDxe/DiskCache.c > b/FatPkg/EnhancedFatDxe/DiskCache.c > index 2df0aa09f1..df587810fb 100644 > --- a/FatPkg/EnhancedFatDxe/DiskCache.c > +++ b/FatPkg/EnhancedFatDxe/DiskCache.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > are older than the contents in disk, so they are invalid; just mark th= em > invalid. >=20 > When this function is called by read command, if any entry in this ran= ge > - is dirty, it means that the relative info directly readed from media i= s older > than > + is dirty, it means that the relative info directly read from media is > + older than > than the info in the cache; So need to update the relative info in the= Buffer. >=20 > @param Volume - FAT file system volume. > diff --git a/FatPkg/EnhancedFatDxe/Fat.h b/FatPkg/EnhancedFatDxe/Fat.h > index 98ead5a0fb..46c185c3a9 100644 > --- a/FatPkg/EnhancedFatDxe/Fat.h > +++ b/FatPkg/EnhancedFatDxe/Fat.h > @@ -865,7 +865,7 @@ FatCleanupVolume ( >=20 > @param OFile - The open file. >=20 > - @retval EFI_SUCCESS - Shrinked sucessfully. > + @retval EFI_SUCCESS - Shrinked successfully. > @retval EFI_VOLUME_CORRUPTED - There are errors in the file's cluster= s. >=20 > **/ > @@ -881,7 +881,7 @@ FatShrinkEof ( > @param OFile - The open file. > @param NewSizeInBytes - The new size in bytes of the open file= . >=20 > - @retval EFI_SUCCESS - The file is grown sucessfully. > + @retval EFI_SUCCESS - The file is grown successfully. > @retval EFI_UNSUPPORTED - The file size is larger than 4GB. > @retval EFI_VOLUME_CORRUPTED - There are errors in the files' cluster= s. > @retval EFI_VOLUME_FULL - The volume is full and can not grow th= e file. > @@ -969,7 +969,7 @@ FatComputeFreeInfo ( > @param Handle - The handle of parent device. > @param DiskIo - The DiskIo of parent device. > @param DiskIo2 - The DiskIo2 of parent device. > - @param BlockIo - The BlockIo of parent devicel > + @param BlockIo - The BlockIo of parent device. >=20 > @retval EFI_SUCCESS - Allocate a new volume successfully. > @retval EFI_OUT_OF_RESOURCES - Can not allocate the memory. > @@ -1079,7 +1079,7 @@ FatDestroySubtask ( > @param IFile - The instance of the open file. > @param Task - The task to be executed. >=20 > - @retval EFI_SUCCESS - The task was executed sucessfully. > + @retval EFI_SUCCESS - The task was executed successfully. > @return other - An error occurred when executing the t= ask. >=20 > **/ > @@ -1097,7 +1097,7 @@ FatQueueTask ( > @param IoMode - The access mode. > @param DirtyValue - Set the volume as dirty or not. >=20 > - @retval EFI_SUCCESS - Set the new FAT entry value sucessfull= y. > + @retval EFI_SUCCESS - Set the new FAT entry value successful= ly. > @return other - An error occurred when operation the F= AT entries. >=20 > **/ > @@ -1120,7 +1120,7 @@ FatAccessVolumeDirty ( > @param Task point to task instance. >=20 > @retval EFI_SUCCESS - The operation is performed successfull= y. > - @retval EFI_VOLUME_CORRUPTED - The accesss is > + @retval EFI_VOLUME_CORRUPTED - The access is > @return Others - The status of read/write the disk >=20 > **/ > @@ -1361,7 +1361,7 @@ FatStriCmp ( > @retval EFI_SUCCESS - Open the file successfully. > @retval EFI_INVALID_PARAMETER - The open mode is conflict with the > attributes > or the file name is not valid. > - @retval EFI_NOT_FOUND - Conficts between dir intention and > attribute. > + @retval EFI_NOT_FOUND - Conflicts between dir intention and > attribute. > @retval EFI_WRITE_PROTECTED - Can't open for write if the volume is = read > only. > @retval EFI_ACCESS_DENIED - If the file's attribute is read only, = and the > open is for read-write fail it. > @@ -1710,7 +1710,7 @@ FatCloseDirEnt ( > not be created either). > @retval EFI_INVALID_PARAMETER - The parameter is not valid. > @retval EFI_SUCCESS - Open the file successfully. > - @return other - An error occured when locating the OFi= le. > + @return other - An error occurred when locating the OF= ile. >=20 > **/ > EFI_STATUS > @@ -1728,7 +1728,7 @@ FatLocateOFile ( > @param Volume - FAT file system volume. > @param Name - The file name of the volume. >=20 > - @retval EFI_SUCCESS - Update the volume with the directory e= ntry > sucessfully. > + @retval EFI_SUCCESS - Update the volume with the directory e= ntry > successfully. > @return others - An error occurred when getting volume = label. >=20 > **/ > @@ -1745,7 +1745,7 @@ FatGetVolumeEntry ( > @param Volume - FAT file system volume. > @param Name - The new file name of the volume. >=20 > - @retval EFI_SUCCESS - Update the Volume sucessfully. > + @retval EFI_SUCCESS - Update the Volume successfully. > @retval EFI_UNSUPPORTED - The input label is not a valid volume la= bel. > @return other - An error occurred when setting volume la= bel. >=20 > diff --git a/FatPkg/EnhancedFatDxe/FileName.c > b/FatPkg/EnhancedFatDxe/FileName.c > index bab709d964..256db30954 100644 > --- a/FatPkg/EnhancedFatDxe/FileName.c > +++ b/FatPkg/EnhancedFatDxe/FileName.c > @@ -100,7 +100,7 @@ FatCheckIs8Dot3Name ( >=20 > Trim the trailing blanks of fat name. >=20 > - @param Name - The Char8 string needs to be trimed. > + @param Name - The Char8 string needs to be trimmed. > @param Len - The length of the fat name. >=20 > The real length of the fat name after the trailing blanks are trimmed. > diff --git a/FatPkg/EnhancedFatDxe/FileSpace.c > b/FatPkg/EnhancedFatDxe/FileSpace.c > index 6659036039..0dd66e0c53 100644 > --- a/FatPkg/EnhancedFatDxe/FileSpace.c > +++ b/FatPkg/EnhancedFatDxe/FileSpace.c > @@ -129,7 +129,7 @@ FatGetFatEntry ( > @param Index - The index of the FAT entry of the volu= me. > @param Value - The new value of the FAT entry. >=20 > - @retval EFI_SUCCESS - Set the new FAT entry value sucessfull= y. > + @retval EFI_SUCCESS - Set the new FAT entry value successful= ly. > @retval EFI_VOLUME_CORRUPTED - The FAT type of the volume is error. > @return other - An error occurred when operation the F= AT entries. >=20 > @@ -343,7 +343,7 @@ FatSizeToClusters ( >=20 > @param OFile - The open file. >=20 > - @retval EFI_SUCCESS - Shrinked sucessfully. > + @retval EFI_SUCCESS - Shrinked successfully. > @retval EFI_VOLUME_CORRUPTED - There are errors in the file's cluster= s. >=20 > **/ > @@ -416,7 +416,7 @@ FatShrinkEof ( > @param OFile - The open file. > @param NewSizeInBytes - The new size in bytes of the open file= . >=20 > - @retval EFI_SUCCESS - The file is grown sucessfully. > + @retval EFI_SUCCESS - The file is grown successfully. > @retval EFI_UNSUPPORTED - The file size is larger than 4GB. > @retval EFI_VOLUME_CORRUPTED - There are errors in the files' cluster= s. > @retval EFI_VOLUME_FULL - The volume is full and can not grow th= e file. > diff --git a/FatPkg/EnhancedFatDxe/Info.c b/FatPkg/EnhancedFatDxe/Info.c > index 1c9811cad0..fd4c0278f9 100644 > --- a/FatPkg/EnhancedFatDxe/Info.c > +++ b/FatPkg/EnhancedFatDxe/Info.c > @@ -407,7 +407,7 @@ FatSetFileInfo ( > // > if (OFile->ODir !=3D NULL) { > // > - // Syncronize its dot entry > + // Synchronize its dot entry > // > FatResetODirCursor (OFile); > ASSERT (OFile->Parent !=3D NULL); > diff --git a/FatPkg/EnhancedFatDxe/Init.c b/FatPkg/EnhancedFatDxe/Init.c > index 530154bd25..4e6bd9d0fd 100644 > --- a/FatPkg/EnhancedFatDxe/Init.c > +++ b/FatPkg/EnhancedFatDxe/Init.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > @param Handle - The handle of parent device. > @param DiskIo - The DiskIo of parent device. > @param DiskIo2 - The DiskIo2 of parent device. > - @param BlockIo - The BlockIo of parent devicel > + @param BlockIo - The BlockIo of parent device. >=20 > @retval EFI_SUCCESS - Allocate a new volume successfully. > @retval EFI_OUT_OF_RESOURCES - Can not allocate the memory. > diff --git a/FatPkg/EnhancedFatDxe/Misc.c b/FatPkg/EnhancedFatDxe/Misc.c > index bc19695fc9..a005036d46 100644 > --- a/FatPkg/EnhancedFatDxe/Misc.c > +++ b/FatPkg/EnhancedFatDxe/Misc.c > @@ -114,7 +114,7 @@ FatDestroySubtask ( > @param IFile - The instance of the open file. > @param Task - The task to be executed. >=20 > - @retval EFI_SUCCESS - The task was executed sucessfully. > + @retval EFI_SUCCESS - The task was executed successfully. > @return other - An error occurred when executing the t= ask. >=20 > **/ > @@ -219,7 +219,7 @@ FatQueueTask ( > @param IoMode - The access mode. > @param DirtyValue - Set the volume as dirty or not. >=20 > - @retval EFI_SUCCESS - Set the new FAT entry value sucessfull= y. > + @retval EFI_SUCCESS - Set the new FAT entry value successful= ly. > @return other - An error occurred when operation the F= AT entries. >=20 > **/ > @@ -304,7 +304,7 @@ FatOnAccessComplete ( > @param Task point to task instance. >=20 > @retval EFI_SUCCESS - The operation is performed successfull= y. > - @retval EFI_VOLUME_CORRUPTED - The accesss is > + @retval EFI_VOLUME_CORRUPTED - The access is > @return Others - The status of read/write the disk >=20 > **/ > diff --git a/FatPkg/EnhancedFatDxe/Open.c > b/FatPkg/EnhancedFatDxe/Open.c index cfd99baf7d..1b716e0cdf 100644 > --- a/FatPkg/EnhancedFatDxe/Open.c > +++ b/FatPkg/EnhancedFatDxe/Open.c > @@ -74,7 +74,7 @@ FatAllocateIFile ( > @retval EFI_SUCCESS - Open the file successfully. > @retval EFI_INVALID_PARAMETER - The open mode is conflict with the > attributes > or the file name is not valid. > - @retval EFI_NOT_FOUND - Conficts between dir intention and > attribute. > + @retval EFI_NOT_FOUND - Conflicts between dir intention and > attribute. > @retval EFI_WRITE_PROTECTED - Can't open for write if the volume is = read > only. > @retval EFI_ACCESS_DENIED - If the file's attribute is read only, = and the > open is for read-write fail it. > diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei/FatLiteApi.c inde= x > b9f883b9e0..8c7c6e5258 100644 > --- a/FatPkg/FatPei/FatLiteApi.c > +++ b/FatPkg/FatPei/FatLiteApi.c > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > PEI_FAT_PRIVATE_DATA *mPrivateData =3D NULL; >=20 > /** > - BlockIo installation nofication function. Find out all the current Blo= ckIO > + BlockIo installation notification function. Find out all the current > + BlockIO > PPIs in the system and add them into private data. Assume there is >=20 > @param PeiServices General purpose services available to = every > @@ -256,7 +256,7 @@ FatPeimEntry ( >=20 > Status =3D PeiServicesAllocatePages ( > EfiBootServicesCode, > - (sizeof (PEI_FAT_PRIVATE_DATA) - 1) / > PEI_FAT_MEMMORY_PAGE_SIZE + 1, > + (sizeof (PEI_FAT_PRIVATE_DATA) - 1) / > + PEI_FAT_MEMORY_PAGE_SIZE + 1, > &Address > ); > if (EFI_ERROR (Status)) { > @@ -600,7 +600,7 @@ LoadRecoveryCapsule ( > @param FileName The recovery file name to find. > @param Handle The output file handle. >=20 > - @retval EFI_DEVICE_ERROR Some error occured when operating the > FAT > + @retval EFI_DEVICE_ERROR Some error occurred when operating the > FAT > volume. > @retval EFI_NOT_FOUND The recovery file was not found. > @retval EFI_SUCCESS The recovery file was successfully fou= nd on the > diff --git a/FatPkg/FatPei/FatLitePeim.h b/FatPkg/FatPei/FatLitePeim.h in= dex > 18534b9abb..9cacf74ace 100644 > --- a/FatPkg/FatPei/FatLitePeim.h > +++ b/FatPkg/FatPei/FatLitePeim.h > @@ -40,7 +40,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #define PEI_FAT_MAX_BLOCK_IO_PPI 32 > #define PEI_FAT_MAX_VOLUME 64 >=20 > -#define PEI_FAT_MEMMORY_PAGE_SIZE 0x1000 > +#define PEI_FAT_MEMORY_PAGE_SIZE 0x1000 >=20 > // > // Data Structures > @@ -194,7 +194,7 @@ typedef struct { > @param FileName The recovery file name to find. > @param Handle The output file handle. >=20 > - @retval EFI_DEVICE_ERROR Some error occured when operating the > FAT > + @retval EFI_DEVICE_ERROR Some error occurred when operating the > FAT > volume. > @retval EFI_NOT_FOUND The recovery file was not found. > @retval EFI_SUCCESS The recovery file was successfully fou= nd on the > diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c index > 233a66b974..4028c535f3 100644 > --- a/FatPkg/FatPei/Gpt.c > +++ b/FatPkg/FatPei/Gpt.c > @@ -48,7 +48,7 @@ PartitionCheckGptHeaderCRC ( > GptHdrCrc =3D PartHeader->Header.CRC32; >=20 > // > - // Set CRC field to zero when doing calcuation > + // Set CRC field to zero when doing calculation > // > PartHeader->Header.CRC32 =3D 0; >=20 > diff --git a/FatPkg/FatPei/Mbr.c b/FatPkg/FatPei/Mbr.c index > 0b6375af6d..5b01604c07 100644 > --- a/FatPkg/FatPei/Mbr.c > +++ b/FatPkg/FatPei/Mbr.c > @@ -52,7 +52,7 @@ PartitionValidMbr ( > if (EndingLBA > LastLba) { > // > // Compatability Errata: > - // Some systems try to hide drive space with thier INT 13h driver > + // Some systems try to hide drive space with their INT 13h > + driver > // This does not hide space from the OS driver. This means the MB= R > // that gets created from DOS is smaller than the MBR created fro= m > // a real OS (NT & Win98). This leads to BlockIo->LastBlock being > -- > 2.21.0.windows.1