From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.217.1571876511743746535 for ; Wed, 23 Oct 2019 17:21:52 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 17:21:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,222,1569308400"; d="scan'208";a="201303955" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 23 Oct 2019 17:21:49 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 23 Oct 2019 17:21:48 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 23 Oct 2019 17:21:48 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.165]) with mapi id 14.03.0439.000; Thu, 24 Oct 2019 08:21:47 +0800 From: "Ni, Ray" To: "Dong, Eric" , "devel@edk2.groups.io" , "Kinney, Michael D" CC: Sean Brogan , Laszlo Ersek Subject: Re: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc Thread-Topic: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to UefiCpuPkg.dsc Thread-Index: AQHViQvl6rgLZTkO50SLJCQ2FIApTqdoZZkAgACJ+hA= Date: Thu, 24 Oct 2019 00:21:46 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C32E9B5@SHSMSX104.ccr.corp.intel.com> References: <20191022190659.26912-1-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Dong, Eric > Sent: Thursday, October 24, 2019 8:07 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Sean Brogan ; Ni, Ray ; > Laszlo Ersek > Subject: RE: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to > UefiCpuPkg.dsc >=20 > Reviewed-by: Eric Dong >=20 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Wednesday, October 23, 2019 3:07 AM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Dong, Eric > ; Ni, Ray ; Laszlo Ersek > > Subject: [edk2-devel] [Patch] UefiCpuPkg: Add missing components to > UefiCpuPkg.dsc >=20 > From: Sean Brogan >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2255 >=20 > Update UefiCpuPkg.dsc to guarantee all libraries and modules are always = built. > Add the following components. >=20 > * UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf > * UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf >=20 > ResetVector.inf is a binary INF, so no source builds are triggered from = adding > this line. However, a build with this component does verify the content= s of the > INF file. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Michael D Kinney > --- > UefiCpuPkg/UefiCpuPkg.dsc | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index > e7dfe30eda..d28cb5cccb 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -121,6 +121,7 @@ [Components.IA32, Components.X64] > UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf > UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf > UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.inf > + UefiCpuPkg/Library/CpuCommonFeaturesLib/CpuCommonFeaturesLib.inf > UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.i= nf >=20 > UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.i= nf > UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.i= nf > @@ -146,6 +147,7 @@ [Components.IA32, Components.X64] >=20 > SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeatures > LibStm.inf > } > UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf > + UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf >=20 > [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES > -- > 2.21.0.windows.1 >=20 >=20 >=20