From: "Ni, Ray" <ray.ni@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>, "Lou, Yun" <yun.lou@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h
Date: Thu, 7 Nov 2019 01:58:58 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C352902@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F83EBF9@shsmsx102.ccr.corp.intel.com>
I see. PciIo or UsbIo instance is installed with a different GUID and consumer needs to parse the device path to understand what kind of instance (PciIo or UsbIo) should be used.
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Wednesday, November 6, 2019 4:25 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Lou, Yun <yun.lou@intel.com>
> Subject: RE: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h
>
> HI
> Good comment. Let me answer it in 2 parts.
>
> 1) The consumer may locate the deice path to know the device type. In this part, you can treat this as redundant
> information.
>
> 2) But we still need a new GUID, because I will install the device access protocol on this new GUID for the temporary access
> for the authentication driver only.
>
> I don't want to install the device access protocol to the original UEFI spec defined GUID to notify everyone that the device
> is ready to use, because I have seen some device drivers have callback function (such as ATA passthru, or NVME passthru)
> to start access the device once the device access protocol is installed.
>
>
> Thank you
> Yao Jiewen
>
> > -----Original Message-----
> > From: Ni, Ray <ray.ni@intel.com>
> > Sent: Wednesday, November 6, 2019 3:56 PM
> > To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> > Lou, Yun <yun.lou@intel.com>
> > Subject: RE: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add
> > DeviceSecurity.h
> >
> > > + ///
> > > + /// Type of the device.
> > > + /// This field is also served as a device Access protocol GUID.
> > > + /// The device access protocol is installed on the DeviceHandle.
> > > + /// The device access protocol is device specific.
> > > + /// EDKII_DEVICE_IDENTIFIER_TYPE_PCI_GUID means the device access
> > protocol is PciIo.
> > > + /// EDKII_DEVICE_IDENTIFIER_TYPE_USB_GUID means the device access
> > protocol is UsbIo.
> > > + ///
> > > + EFI_GUID DeviceType;
> >
> > Do we still need DeviceType? Consumer can query the Handle to understand the
> > device type.
next prev parent reply other threads:[~2019-11-07 1:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 12:30 [PATCH V2 0/4] Add SPDM device security Yao, Jiewen
2019-10-31 12:30 ` [PATCH V2 1/4] MdePkg/Include: Add DMTF SPDM definition Yao, Jiewen
2019-11-06 14:38 ` Liming Gao
2019-11-07 0:25 ` Yao, Jiewen
[not found] ` <15D4B9B24059B4F1.19610@groups.io>
2019-11-07 0:57 ` [edk2-devel] " Yao, Jiewen
2019-10-31 12:30 ` [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h Yao, Jiewen
2019-11-06 7:55 ` [edk2-devel] " Ni, Ray
2019-11-06 8:25 ` Yao, Jiewen
2019-11-07 1:58 ` Ni, Ray [this message]
[not found] ` <15D4BEC95EBB70CB.18056@groups.io>
2019-11-07 4:31 ` Ni, Ray
2019-11-07 7:13 ` Yao, Jiewen
2019-11-07 7:16 ` Ni, Ray
2019-10-31 12:30 ` [PATCH V2 3/4] MdeModulePkg/dec: Add EdkiiDeviceSecurityProtocolGuid Yao, Jiewen
2019-10-31 12:30 ` [PATCH V2 4/4] MdeModulePkg/Pci: Add DeviceSecurity support Yao, Jiewen
2019-11-07 4:42 ` Ni, Ray
2019-11-07 7:05 ` Yao, Jiewen
[not found] ` <15D2BB2D773DBDBA.23805@groups.io>
2019-11-06 6:47 ` [edk2-devel] [PATCH V2 1/4] MdePkg/Include: Add DMTF SPDM definition Yao, Jiewen
[not found] ` <15D2BB2E5CC7FD95.31603@groups.io>
2019-11-06 6:47 ` [edk2-devel] [PATCH V2 4/4] MdeModulePkg/Pci: Add DeviceSecurity support Yao, Jiewen
[not found] ` <15D2BB2DC41C838D.31603@groups.io>
2019-11-06 6:47 ` [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h Yao, Jiewen
[not found] ` <15D2BB2E0995721D.31603@groups.io>
2019-11-06 6:47 ` [edk2-devel] [PATCH V2 3/4] MdeModulePkg/dec: Add EdkiiDeviceSecurityProtocolGuid Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C352902@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox