public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Wang, Jian J" <jian.j.wang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [PATCH 0/2] Reserve page 0 for NULL pointer detection
Date: Thu, 7 Nov 2019 02:10:42 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C35299F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191106131333.4684-1-jian.j.wang@intel.com>

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Wang, Jian J <jian.j.wang@intel.com>
> Sent: Wednesday, November 6, 2019 9:14 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Sean Brogan <sean.brogan@microsoft.com>
> Subject: [PATCH 0/2] Reserve page 0 for NULL pointer detection
> 
> When a boot loader examines the memory map, it can see that location 0
> is available memory. If it chooses to use that memory, and
> PcdNullPointerDetectionPropertyMask is enabled, use of memory in page 0
> will cause an exception. This does occur when running the memtest86
> program.
> 
> Leaving page 0 available is for legacy support purpose. Since we have
> deprecated the support of legacy, the solution is just reserving it so
> that it cannot be allocated for other uses.
> 
> Tests:
>   - run memtest86 with PcdNullPointerDetectionPropertyMask set to 0x03
>   - run memtest86 with PcdNullPointerDetectionPropertyMask set to 0x83
>   - boot OVMF into Windows 7 with PcdNullPointerDetectionPropertyMask set to 0x83
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1885
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> 
> Jian J Wang (2):
>   MdeModulePkg/DxeIplPeim: reserve page 0 for NULL pointer detection
>   MdeModulePkg/Core/Dxe: free page 0 after disabling NULL pointer
>     detection
> 
>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c   | 5 +++++
>  MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c | 4 ++++
>  MdeModulePkg/Core/DxeIplPeim/X64/DxeLoadFunc.c  | 4 ++++
>  3 files changed, 13 insertions(+)
> 
> --
> 2.17.1.windows.2


  parent reply	other threads:[~2019-11-07  2:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 13:13 [PATCH 0/2] Reserve page 0 for NULL pointer detection Wang, Jian J
2019-11-06 13:13 ` [PATCH 1/2] MdeModulePkg/DxeIplPeim: reserve " Wang, Jian J
2019-11-06 13:13 ` [PATCH 2/2] MdeModulePkg/Core/Dxe: free page 0 after disabling " Wang, Jian J
2019-11-07  2:10 ` Ni, Ray [this message]
2019-11-09  3:03   ` [PATCH 0/2] Reserve page 0 for " Wang, Jian J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C35299F@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox