From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.101.1573101117259596730 for ; Wed, 06 Nov 2019 20:31:57 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 20:31:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="206044295" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga006.jf.intel.com with ESMTP; 06 Nov 2019 20:31:56 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 20:31:56 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 20:31:55 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by shsmsx102.ccr.corp.intel.com ([169.254.2.108]) with mapi id 14.03.0439.000; Thu, 7 Nov 2019 12:31:54 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Ni, Ray" , "Yao, Jiewen" CC: "Wang, Jian J" , "Wu, Hao A" , "Lou, Yun" Subject: Re: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h Thread-Topic: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h Thread-Index: AQHVj+cEIaKpMCv2u0qN7YFGo9tarKd9zqVA//+CzwCAAaG0oIAANBLQ Date: Thu, 7 Nov 2019 04:31:53 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C352CE8@SHSMSX104.ccr.corp.intel.com> References: <20191031123012.16020-1-jiewen.yao@intel.com> <20191031123012.16020-3-jiewen.yao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C35174D@SHSMSX104.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F83EBF9@shsmsx102.ccr.corp.intel.com> <15D4BEC95EBB70CB.18056@groups.io> In-Reply-To: <15D4BEC95EBB70CB.18056@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, "xxx_DEVICE_IDENTIFIER_TYPE_xxx" sounds a bit strange to me because I feel "IDENTIFIER" and "TYPE" are different properties to describe a devi= ce. Or you think some other GUIDs may be defined in future as the device ID? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Thursday, November 7, 2019 9:59 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A = ; > Lou, Yun > Subject: Re: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add > DeviceSecurity.h >=20 > I see. PciIo or UsbIo instance is installed with a different GUID and co= nsumer > needs to parse the device path to understand what kind of instance (PciI= o or > UsbIo) should be used. >=20 > > -----Original Message----- > > From: Yao, Jiewen > > Sent: Wednesday, November 6, 2019 4:25 PM > > To: Ni, Ray ; devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > ; Lou, Yun > > Subject: RE: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add > > DeviceSecurity.h > > > > HI > > Good comment. Let me answer it in 2 parts. > > > > 1) The consumer may locate the deice path to know the device type. In > > this part, you can treat this as redundant information. > > > > 2) But we still need a new GUID, because I will install the device > > access protocol on this new GUID for the temporary access for the > authentication driver only. > > > > I don't want to install the device access protocol to the original > > UEFI spec defined GUID to notify everyone that the device is ready to > > use, because I have seen some device drivers have callback function (s= uch > as ATA passthru, or NVME passthru) to start access the device once the > device access protocol is installed. > > > > > > Thank you > > Yao Jiewen > > > > > -----Original Message----- > > > From: Ni, Ray > > > Sent: Wednesday, November 6, 2019 3:56 PM > > > To: devel@edk2.groups.io; Yao, Jiewen > > > Cc: Wang, Jian J ; Wu, Hao A > > > ; Lou, Yun > > > Subject: RE: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add > > > DeviceSecurity.h > > > > > > > + /// > > > > + /// Type of the device. > > > > + /// This field is also served as a device Access protocol GUID. > > > > + /// The device access protocol is installed on the DeviceHandle= . > > > > + /// The device access protocol is device specific. > > > > + /// EDKII_DEVICE_IDENTIFIER_TYPE_PCI_GUID means the device > access > > > protocol is PciIo. > > > > + /// EDKII_DEVICE_IDENTIFIER_TYPE_USB_GUID means the device > access > > > protocol is UsbIo. > > > > + /// > > > > + EFI_GUID DeviceType; > > > > > > Do we still need DeviceType? Consumer can query the Handle to > > > understand the device type. >=20 >=20