From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by mx.groups.io with SMTP id smtpd.web10.734.1573107101512480252
 for <devel@edk2.groups.io>;
 Wed, 06 Nov 2019 22:11:41 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 22:11:41 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; 
   d="scan'208";a="353705730"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
  by orsmga004.jf.intel.com with ESMTP; 06 Nov 2019 22:11:40 -0800
Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 6 Nov 2019 22:11:40 -0800
Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by
 fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 6 Nov 2019 22:11:40 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by
 SHSMSX154.ccr.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0439.000;
 Thu, 7 Nov 2019 14:11:37 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>, "Lou, Yun"
	<yun.lou@intel.com>
Subject: Re: [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.
Thread-Topic: [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid
 definition.
Thread-Index: AQHVj+crNCa9ojk/hEivGU9dbKYkxKd/Q+jg
Date: Thu, 7 Nov 2019 06:11:37 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C352E25@SHSMSX104.ccr.corp.intel.com>
References: <20191031123127.10900-1-jiewen.yao@intel.com>
 <20191031123127.10900-4-jiewen.yao@intel.com>
In-Reply-To: <20191031123127.10900-4-jiewen.yao@intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Jiewen,
Can you add comments to explain the protocol and the associated header file=
 path?
Like:
  ## Guid for EDKII implementation extension, used to indaicate there are b=
it fields in the varstore.
  #  Include/Guid/MdeModuleHii.h
  gEdkiiIfrBitVarstoreGuid  =3D {0x82DDD68B, 0x9163, 0x4187, {0x9B, 0x27, 0=
x20, 0xA8, 0xFD, 0x60,0xA7, 0x1D}}

> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Thursday, October 31, 2019 8:31 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Lou, Yun <yun.lou@intel.com>
> Subject: [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2303
>=20
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Yun Lou <yun.lou@intel.com>
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> index 3079fc2869..8c8cd9f49d 100644
> --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -53,6 +53,7 @@
>=20
>  [Protocols]
>    gEdkiiPlatformVTdPolicyProtocolGuid =3D { 0x3d17e448, 0x466, 0x4e20, {=
 0x99,
> 0x9f, 0xb2, 0xe1, 0x34, 0x88, 0xee, 0x22 }}
> +  gEdkiiDeviceSecurityPolicyProtocolGuid =3D {0x7ea41a99, 0x5e32, 0x4c97=
,
> {0x88, 0xc4, 0xd6, 0xe7, 0x46, 0x84, 0x9, 0xd4}}
>=20
>  [PcdsFixedAtBuild, PcdsPatchableInModule]
>    ## Error code for VTd error.<BR><BR>
> --
> 2.19.2.windows.1