Re: [edk2-devel] [PATCH V3 0/4] Add SPDM device security

Re: [edk2-devel] [PATCH V3 0/4] Add SPDM device security

[Yao, Jiewen]

Hi
I forget to mention that this patch is also pushed to git.

The EDKII repo update is at https://github.com/jyao1/edk2/tree/DeviceSecurityMasterV3
The EDKII platform repo update is at https://github.com/jyao1/edk2-platforms/tree/DeviceSecurityMasterV3

Thank you
Yao Jiewen

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
> Sent: Thursday, November 7, 2019 9:38 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH V3 0/4] Add SPDM device security
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
> 
> ========= v3 =============
> 
> The patch addresses the feedback below:
> Liming Gao:
> 1) specify the spec version in file header for SPDM.
> 
> Ray Ni:
> 1) create a standalone function like PciDeviceAuthenticate() and
> move the new code to that function then call it from CreatePciIoDevice
> 
> ========= v2 =============
> This patch series add support for device security based
> upon the DMTF SPDM specification.
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_0.95a
> .zip
> 
> We did design review at 18 Oct, 2019.
> https://edk2.groups.io/g/devel/files/Designs/2019/1018
> And the feedback from the meeting is addressed.
> https://edk2.groups.io/g/devel/files/Designs/2019/1018/EDKII-
> Device%20Firmware%20Security%20v2.pdf
> 
> We add the Device security protocol in EDKII repo.
> PCI bus driver consumes the interface.
> If there is no producer, the PCI bus driver keeps current behavior.
> 
> So far, we only provide the producer what follows Intel
> PCI security spec.
> https://www.intel.com/content/www/us/en/io/pci-express/pcie-device-
> security-enhancements-spec.html
> The implementation is put to EDKII platform repo.
> 
> The EDKII repo update is at
> https://github.com/jyao1/edk2/tree/DeviceSecurityMasterV2
> The EDKII platform repo update is at https://github.com/jyao1/edk2-
> platforms/tree/DeviceSecurityMasterV2
> 
> The validation has been done on a Intel internal platform.
> The device measurement can be shown in TCG event log.
> 
> signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> 
> Jiewen Yao (4):
>   MdePkg/Include: Add DMTF SPDM definition.
>   MdeModulePkg/Include: Add DeviceSecurity.h
>   MdeModulePkg/dec: Add EdkiiDeviceSecurityProtocolGuid.
>   MdeModulePkg/Pci: Add DeviceSecurity support.
> 
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c       |  12 +-
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h       |   1 +
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf  |   4 +-
>  .../Bus/Pci/PciBusDxe/PciEnumeratorSupport.c  |  77 +++++
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c       |   4 +-
>  .../Include/Protocol/DeviceSecurity.h         | 162 +++++++++
>  MdeModulePkg/MdeModulePkg.dec                 |   5 +
>  MdePkg/Include/IndustryStandard/Spdm.h        | 320 ++++++++++++++++++
>  8 files changed, 581 insertions(+), 4 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Protocol/DeviceSecurity.h
>  create mode 100644 MdePkg/Include/IndustryStandard/Spdm.h
> 
> --
> 2.19.2.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH V3 0/4] Add SPDM device security

[Ni, Ray]

For changes in edk2 repo, Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> Jiewen
> Sent: Thursday, November 7, 2019 9:41 PM
> To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: Re: [edk2-devel] [PATCH V3 0/4] Add SPDM device security
> 
> Hi
> I forget to mention that this patch is also pushed to git.
> 
> The EDKII repo update is at
> https://github.com/jyao1/edk2/tree/DeviceSecurityMasterV3
> The EDKII platform repo update is at https://github.com/jyao1/edk2-
> platforms/tree/DeviceSecurityMasterV3
> 
> Thank you
> Yao Jiewen
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao,
> > Jiewen
> > Sent: Thursday, November 7, 2019 9:38 PM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH V3 0/4] Add SPDM device security
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2303
> >
> > ========= v3 =============
> >
> > The patch addresses the feedback below:
> > Liming Gao:
> > 1) specify the spec version in file header for SPDM.
> >
> > Ray Ni:
> > 1) create a standalone function like PciDeviceAuthenticate() and move
> > the new code to that function then call it from CreatePciIoDevice
> >
> > ========= v2 =============
> > This patch series add support for device security based upon the DMTF
> > SPDM specification.
> >
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_0
> > .95a
> > .zip
> >
> > We did design review at 18 Oct, 2019.
> > https://edk2.groups.io/g/devel/files/Designs/2019/1018
> > And the feedback from the meeting is addressed.
> > https://edk2.groups.io/g/devel/files/Designs/2019/1018/EDKII-
> > Device%20Firmware%20Security%20v2.pdf
> >
> > We add the Device security protocol in EDKII repo.
> > PCI bus driver consumes the interface.
> > If there is no producer, the PCI bus driver keeps current behavior.
> >
> > So far, we only provide the producer what follows Intel PCI security
> > spec.
> > https://www.intel.com/content/www/us/en/io/pci-express/pcie-device-
> > security-enhancements-spec.html
> > The implementation is put to EDKII platform repo.
> >
> > The EDKII repo update is at
> > https://github.com/jyao1/edk2/tree/DeviceSecurityMasterV2
> > The EDKII platform repo update is at https://github.com/jyao1/edk2-
> > platforms/tree/DeviceSecurityMasterV2
> >
> > The validation has been done on a Intel internal platform.
> > The device measurement can be shown in TCG event log.
> >
> > signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> >
> > Jiewen Yao (4):
> >   MdePkg/Include: Add DMTF SPDM definition.
> >   MdeModulePkg/Include: Add DeviceSecurity.h
> >   MdeModulePkg/dec: Add EdkiiDeviceSecurityProtocolGuid.
> >   MdeModulePkg/Pci: Add DeviceSecurity support.
> >
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c       |  12 +-
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h       |   1 +
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf  |   4 +-
> >  .../Bus/Pci/PciBusDxe/PciEnumeratorSupport.c  |  77 +++++
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciLib.c       |   4 +-
> >  .../Include/Protocol/DeviceSecurity.h         | 162 +++++++++
> >  MdeModulePkg/MdeModulePkg.dec                 |   5 +
> >  MdePkg/Include/IndustryStandard/Spdm.h        | 320
> ++++++++++++++++++
> >  8 files changed, 581 insertions(+), 4 deletions(-)  create mode
> > 100644 MdeModulePkg/Include/Protocol/DeviceSecurity.h
> >  create mode 100644 MdePkg/Include/IndustryStandard/Spdm.h
> >
> > --
> > 2.19.2.windows.1
> >
> >
> >
> 
> 
>