* EDK II Maintainers please test the pull request commit gate @ 2019-11-07 2:24 Michael D Kinney 2019-11-07 11:00 ` [edk2-devel] " Laszlo Ersek ` (2 more replies) 0 siblings, 3 replies; 11+ messages in thread From: Michael D Kinney @ 2019-11-07 2:24 UTC (permalink / raw) To: devel@edk2.groups.io, Kinney, Michael D EDK II Maintainers, Please take a few minutes to test the GitHub pull request commit gate feature under review in the edk2-staging/edk2-ci branch. This will be the only method to push patches to the edk2 repo in the near future, and we want all current EDK II Maintainers to make sure they know how to use this new process on the edk2-staging repo before it is activated on the edk2 repo. Please perform the following steps: * Create a personal fork of the edk2-staging repo. * Check out the edk2-ci branch from your personal fork of the edk2-staging repo * Create a new branch based on the edk2-ci branch * Edit the file SampleFile.txt in the root of this branch and add an Acked-by: <your email> tag to the end of this file. * Submit a pull request against the Tianocore edk2-staging/edk2-ci. Set the 'push' label so the change to SampleFile.txt will be committed if all checks pass. NOTE: Make sure you select the 'edk2-ci' branch. The default branch for the edk2-staging repo is the 'about' branch and the pull request will not work against the 'about' branch. * Verify that all checks pass and your change to SampleFile.txt was merged into the edk2-staging/edk2-ci branch. For those that prefer command line tools over a WebUI, the command line utility called 'hub' can be used to submit a pull request and check the status of a pull request. * https://github.com/github/hub * https://github.com/github/hub/releases * https://hub.github.com/hub.1.html Thanks, Mike ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-07 2:24 EDK II Maintainers please test the pull request commit gate Michael D Kinney @ 2019-11-07 11:00 ` Laszlo Ersek 2019-11-07 15:18 ` Liming Gao 2019-11-07 19:26 ` Michael D Kinney 2019-11-08 14:49 ` Philippe Mathieu-Daudé 2019-11-11 5:42 ` Ni, Ray 2 siblings, 2 replies; 11+ messages in thread From: Laszlo Ersek @ 2019-11-07 11:00 UTC (permalink / raw) To: devel, michael.d.kinney On 11/07/19 03:24, Michael D Kinney wrote: > EDK II Maintainers, > > Please take a few minutes to test the GitHub pull > request commit gate feature under review in the > edk2-staging/edk2-ci branch. This will be the only > method to push patches to the edk2 repo in the near > future, and we want all current EDK II Maintainers to > make sure they know how to use this new process on > the edk2-staging repo before it is activated on the > edk2 repo. > > Please perform the following steps: > * Create a personal fork of the edk2-staging repo. Slight but relevant clarification: please create a personal fork of the edk2-staging repo *on GitHub.com*. > * Check out the edk2-ci branch from your personal > fork of the edk2-staging repo > * Create a new branch based on the edk2-ci branch > * Edit the file SampleFile.txt in the root of this > branch and add an Acked-by: <your email> tag to > the end of this file. > * Submit a pull request against the Tianocore > edk2-staging/edk2-ci. Set the 'push' label so > the change to SampleFile.txt will be committed > if all checks pass. > > NOTE: Make sure you select the 'edk2-ci' branch. > The default branch for the edk2-staging repo is > the 'about' branch and the pull request will not > work against the 'about' branch. > > * Verify that all checks pass and your change to > SampleFile.txt was merged into the > edk2-staging/edk2-ci branch. > > For those that prefer command line tools over a WebUI, > the command line utility called 'hub' can be used to > submit a pull request and check the status of a pull > request. > > * https://github.com/github/hub > * https://github.com/github/hub/releases > * https://hub.github.com/hub.1.html I've gone through the above (except the personal Acked-by tag) earlier, successfully: https://github.com/tianocore/edk2-staging/pull/99 Thanks! Laszlo ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-07 11:00 ` [edk2-devel] " Laszlo Ersek @ 2019-11-07 15:18 ` Liming Gao 2019-11-07 19:33 ` Michael D Kinney 2019-11-07 19:26 ` Michael D Kinney 1 sibling, 1 reply; 11+ messages in thread From: Liming Gao @ 2019-11-07 15:18 UTC (permalink / raw) To: devel@edk2.groups.io, lersek@redhat.com, Kinney, Michael D I do my test on https://github.com/tianocore/edk2-staging/pull/60. But, I have not tested hub utility. Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek > Sent: Thursday, November 7, 2019 7:01 PM > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com> > Subject: Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate > > On 11/07/19 03:24, Michael D Kinney wrote: > > EDK II Maintainers, > > > > Please take a few minutes to test the GitHub pull > > request commit gate feature under review in the > > edk2-staging/edk2-ci branch. This will be the only > > method to push patches to the edk2 repo in the near > > future, and we want all current EDK II Maintainers to > > make sure they know how to use this new process on > > the edk2-staging repo before it is activated on the > > edk2 repo. > > > > Please perform the following steps: > > * Create a personal fork of the edk2-staging repo. > > Slight but relevant clarification: please create a personal fork of the > edk2-staging repo *on GitHub.com*. > > > * Check out the edk2-ci branch from your personal > > fork of the edk2-staging repo > > * Create a new branch based on the edk2-ci branch > > * Edit the file SampleFile.txt in the root of this > > branch and add an Acked-by: <your email> tag to > > the end of this file. > > * Submit a pull request against the Tianocore > > edk2-staging/edk2-ci. Set the 'push' label so > > the change to SampleFile.txt will be committed > > if all checks pass. > > > > NOTE: Make sure you select the 'edk2-ci' branch. > > The default branch for the edk2-staging repo is > > the 'about' branch and the pull request will not > > work against the 'about' branch. > > > > * Verify that all checks pass and your change to > > SampleFile.txt was merged into the > > edk2-staging/edk2-ci branch. > > > > For those that prefer command line tools over a WebUI, > > the command line utility called 'hub' can be used to > > submit a pull request and check the status of a pull > > request. > > > > * https://github.com/github/hub > > * https://github.com/github/hub/releases > > * https://hub.github.com/hub.1.html > > I've gone through the above (except the personal Acked-by tag) earlier, > successfully: > > https://github.com/tianocore/edk2-staging/pull/99 > > Thanks! > Laszlo > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-07 15:18 ` Liming Gao @ 2019-11-07 19:33 ` Michael D Kinney 0 siblings, 0 replies; 11+ messages in thread From: Michael D Kinney @ 2019-11-07 19:33 UTC (permalink / raw) To: Gao, Liming, devel@edk2.groups.io, lersek@redhat.com, Kinney, Michael D Hi Liming, Yes. I see that one as a personal build. If you do another one and add the 'push' label, it should auto commit the change to SampleFile.txt. Mike > -----Original Message----- > From: Gao, Liming <liming.gao@intel.com> > Sent: Thursday, November 7, 2019 7:18 AM > To: devel@edk2.groups.io; lersek@redhat.com; Kinney, > Michael D <michael.d.kinney@intel.com> > Subject: RE: [edk2-devel] EDK II Maintainers please test > the pull request commit gate > > I do my test on https://github.com/tianocore/edk2- > staging/pull/60. But, I have not tested hub utility. > > Thanks > Liming > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On > Behalf Of Laszlo > > Ersek > > Sent: Thursday, November 7, 2019 7:01 PM > > To: devel@edk2.groups.io; Kinney, Michael D > > <michael.d.kinney@intel.com> > > Subject: Re: [edk2-devel] EDK II Maintainers please > test the pull > > request commit gate > > > > On 11/07/19 03:24, Michael D Kinney wrote: > > > EDK II Maintainers, > > > > > > Please take a few minutes to test the GitHub pull > request commit > > > gate feature under review in the edk2-staging/edk2- > ci branch. This > > > will be the only method to push patches to the edk2 > repo in the near > > > future, and we want all current EDK II Maintainers > to make sure they > > > know how to use this new process on the edk2-staging > repo before it > > > is activated on the > > > edk2 repo. > > > > > > Please perform the following steps: > > > * Create a personal fork of the edk2-staging repo. > > > > Slight but relevant clarification: please create a > personal fork of > > the edk2-staging repo *on GitHub.com*. > > > > > * Check out the edk2-ci branch from your personal > > > fork of the edk2-staging repo > > > * Create a new branch based on the edk2-ci branch > > > * Edit the file SampleFile.txt in the root of this > > > branch and add an Acked-by: <your email> tag to > > > the end of this file. > > > * Submit a pull request against the Tianocore > > > edk2-staging/edk2-ci. Set the 'push' label so > > > the change to SampleFile.txt will be committed > > > if all checks pass. > > > > > > NOTE: Make sure you select the 'edk2-ci' branch. > > > The default branch for the edk2-staging repo is > > > the 'about' branch and the pull request will not > > > work against the 'about' branch. > > > > > > * Verify that all checks pass and your change to > > > SampleFile.txt was merged into the > > > edk2-staging/edk2-ci branch. > > > > > > For those that prefer command line tools over a > WebUI, the command > > > line utility called 'hub' can be used to submit a > pull request and > > > check the status of a pull request. > > > > > > * https://github.com/github/hub > > > * https://github.com/github/hub/releases > > > * https://hub.github.com/hub.1.html > > > > I've gone through the above (except the personal > Acked-by tag) > > earlier, > > successfully: > > > > https://github.com/tianocore/edk2-staging/pull/99 > > > > Thanks! > > Laszlo > > > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-07 11:00 ` [edk2-devel] " Laszlo Ersek 2019-11-07 15:18 ` Liming Gao @ 2019-11-07 19:26 ` Michael D Kinney 2019-11-08 17:12 ` Laszlo Ersek 1 sibling, 1 reply; 11+ messages in thread From: Michael D Kinney @ 2019-11-07 19:26 UTC (permalink / raw) To: Laszlo Ersek, devel@edk2.groups.io, Kinney, Michael D Laszlo, The hub command line utility also shows an option to create a fork without using the GitHub UI. But since I already have all the relevant forks I needed, I have not tried this feature yet. These GitHub commands are provided by hub: api Low-level GitHub API request interface browse Open a GitHub page in the default browser ci-status Show the status of GitHub checks for a commit compare Open a compare page on GitHub create Create this repository on GitHub and add GitHub as origin delete Delete a repository on GitHub fork Make a fork of a remote repository on GitHub and add as remote issue List or create GitHub issues pr List or checkout GitHub pull requests pull-request Open a pull request on GitHub release List or create GitHub releases sync Fetch git objects from upstream and update branches Mike > -----Original Message----- > From: Laszlo Ersek <lersek@redhat.com> > Sent: Thursday, November 7, 2019 3:01 AM > To: devel@edk2.groups.io; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: Re: [edk2-devel] EDK II Maintainers please test > the pull request commit gate > > On 11/07/19 03:24, Michael D Kinney wrote: > > EDK II Maintainers, > > > > Please take a few minutes to test the GitHub pull > request commit gate > > feature under review in the edk2-staging/edk2-ci > branch. This will be > > the only method to push patches to the edk2 repo in > the near future, > > and we want all current EDK II Maintainers to make > sure they know how > > to use this new process on the edk2-staging repo > before it is > > activated on the > > edk2 repo. > > > > Please perform the following steps: > > * Create a personal fork of the edk2-staging repo. > > Slight but relevant clarification: please create a > personal fork of the edk2-staging repo *on GitHub.com*. > > > * Check out the edk2-ci branch from your personal > > fork of the edk2-staging repo > > * Create a new branch based on the edk2-ci branch > > * Edit the file SampleFile.txt in the root of this > > branch and add an Acked-by: <your email> tag to > > the end of this file. > > * Submit a pull request against the Tianocore > > edk2-staging/edk2-ci. Set the 'push' label so > > the change to SampleFile.txt will be committed > > if all checks pass. > > > > NOTE: Make sure you select the 'edk2-ci' branch. > > The default branch for the edk2-staging repo is > > the 'about' branch and the pull request will not > > work against the 'about' branch. > > > > * Verify that all checks pass and your change to > > SampleFile.txt was merged into the > > edk2-staging/edk2-ci branch. > > > > For those that prefer command line tools over a WebUI, > the command > > line utility called 'hub' can be used to submit a pull > request and > > check the status of a pull request. > > > > * https://github.com/github/hub > > * https://github.com/github/hub/releases > > * https://hub.github.com/hub.1.html > > I've gone through the above (except the personal Acked- > by tag) earlier, > successfully: > > https://github.com/tianocore/edk2-staging/pull/99 > > Thanks! > Laszlo ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-07 19:26 ` Michael D Kinney @ 2019-11-08 17:12 ` Laszlo Ersek 2019-11-08 17:21 ` Michael D Kinney 0 siblings, 1 reply; 11+ messages in thread From: Laszlo Ersek @ 2019-11-08 17:12 UTC (permalink / raw) To: devel, michael.d.kinney Hi Mike, On 11/07/19 20:26, Michael D Kinney wrote: > Laszlo, > > The hub command line utility also shows an option to > create a fork without using the GitHub UI. But since I > already have all the relevant forks I needed, I have not > tried this feature yet. sorry, I was unclear with my "fork on github.com" adjustment. I didn't mean that people were required to use the github *UI* for the fork operation. Instead, I meant that the data store inside <github.com> had to learn about the "fork relationship" between the tianocore/edk2-staging repo, and the <MaintainerAccount>/edk2-staging repo. Because, in my vocabulary, if I enter my local *edk2* clone, and run the following commands: $ git remote add -f --no-tags staging \ https://github.com/tianocore/edk2-staging.git $ git checkout -b ci-test-1 staging/edk2-ci $ [modify files] $ git add ... $ git commit $ git push lersek-edk2 ci-test-1 then I *have* forked the edk2-staging repo. It's because now I'm exposing a public topic branch that is the derivative of the edk2-staging/edk2-ci branch. But, this is not what the test procedure requires. The test procedure requires each maintainer to tell github explicitly, "I am now forking edk2-staging under my account, the way github (re)defines 'forking'". That's *not* what "forking" means in base git terminology, in my opinion, regardless of whether a maintainer implements the github kind of forking on the github WebUI, or with the "hub" command line utility. In brief, I wanted to say, "what github (the service) calls a fork is quite a bit more restrictive than what base git calls a fork, so please let's clearly require the github kind in the instructions". Thanks Laszlo >> -----Original Message----- >> From: Laszlo Ersek <lersek@redhat.com> >> Sent: Thursday, November 7, 2019 3:01 AM >> To: devel@edk2.groups.io; Kinney, Michael D >> <michael.d.kinney@intel.com> >> Subject: Re: [edk2-devel] EDK II Maintainers please test >> the pull request commit gate >> >> On 11/07/19 03:24, Michael D Kinney wrote: >>> EDK II Maintainers, >>> >>> Please take a few minutes to test the GitHub pull >> request commit gate >>> feature under review in the edk2-staging/edk2-ci >> branch. This will be >>> the only method to push patches to the edk2 repo in >> the near future, >>> and we want all current EDK II Maintainers to make >> sure they know how >>> to use this new process on the edk2-staging repo >> before it is >>> activated on the >>> edk2 repo. >>> >>> Please perform the following steps: >>> * Create a personal fork of the edk2-staging repo. >> >> Slight but relevant clarification: please create a >> personal fork of the edk2-staging repo *on GitHub.com*. >> >>> * Check out the edk2-ci branch from your personal >>> fork of the edk2-staging repo >>> * Create a new branch based on the edk2-ci branch >>> * Edit the file SampleFile.txt in the root of this >>> branch and add an Acked-by: <your email> tag to >>> the end of this file. >>> * Submit a pull request against the Tianocore >>> edk2-staging/edk2-ci. Set the 'push' label so >>> the change to SampleFile.txt will be committed >>> if all checks pass. >>> >>> NOTE: Make sure you select the 'edk2-ci' branch. >>> The default branch for the edk2-staging repo is >>> the 'about' branch and the pull request will not >>> work against the 'about' branch. >>> >>> * Verify that all checks pass and your change to >>> SampleFile.txt was merged into the >>> edk2-staging/edk2-ci branch. >>> >>> For those that prefer command line tools over a WebUI, >> the command >>> line utility called 'hub' can be used to submit a pull >> request and >>> check the status of a pull request. >>> >>> * https://github.com/github/hub >>> * https://github.com/github/hub/releases >>> * https://hub.github.com/hub.1.html >> >> I've gone through the above (except the personal Acked- >> by tag) earlier, >> successfully: >> >> https://github.com/tianocore/edk2-staging/pull/99 >> >> Thanks! >> Laszlo > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-08 17:12 ` Laszlo Ersek @ 2019-11-08 17:21 ` Michael D Kinney 0 siblings, 0 replies; 11+ messages in thread From: Michael D Kinney @ 2019-11-08 17:21 UTC (permalink / raw) To: devel@edk2.groups.io, lersek@redhat.com, Kinney, Michael D Laszlo, Agreed. A GitHub fork is required. We can make that clear in the developer process wiki. Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On > Behalf Of Laszlo Ersek > Sent: Friday, November 8, 2019 9:12 AM > To: devel@edk2.groups.io; Kinney, Michael D > <michael.d.kinney@intel.com> > Subject: Re: [edk2-devel] EDK II Maintainers please test > the pull request commit gate > > Hi Mike, > > On 11/07/19 20:26, Michael D Kinney wrote: > > Laszlo, > > > > The hub command line utility also shows an option to > create a fork > > without using the GitHub UI. But since I already have > all the > > relevant forks I needed, I have not tried this feature > yet. > > sorry, I was unclear with my "fork on github.com" > adjustment. > > I didn't mean that people were required to use the > github *UI* for the fork operation. > > Instead, I meant that the data store inside <github.com> > had to learn about the "fork relationship" between the > tianocore/edk2-staging repo, and the > <MaintainerAccount>/edk2-staging repo. > > Because, in my vocabulary, if I enter my local *edk2* > clone, and run the following commands: > > $ git remote add -f --no-tags staging \ > https://github.com/tianocore/edk2-staging.git > $ git checkout -b ci-test-1 staging/edk2-ci $ [modify > files] $ git add ... > $ git commit > $ git push lersek-edk2 ci-test-1 > > then I *have* forked the edk2-staging repo. It's because > now I'm exposing a public topic branch that is the > derivative of the edk2-staging/edk2-ci branch. > > But, this is not what the test procedure requires. The > test procedure requires each maintainer to tell github > explicitly, "I am now forking edk2-staging under my > account, the way github (re)defines 'forking'". > That's *not* what "forking" means in base git > terminology, in my opinion, regardless of whether a > maintainer implements the github kind of forking on the > github WebUI, or with the "hub" command line utility. > > In brief, I wanted to say, "what github (the service) > calls a fork is quite a bit more restrictive than what > base git calls a fork, so please let's clearly require > the github kind in the instructions". > > Thanks > Laszlo > > > >> -----Original Message----- > >> From: Laszlo Ersek <lersek@redhat.com> > >> Sent: Thursday, November 7, 2019 3:01 AM > >> To: devel@edk2.groups.io; Kinney, Michael D > >> <michael.d.kinney@intel.com> > >> Subject: Re: [edk2-devel] EDK II Maintainers please > test the pull > >> request commit gate > >> > >> On 11/07/19 03:24, Michael D Kinney wrote: > >>> EDK II Maintainers, > >>> > >>> Please take a few minutes to test the GitHub pull > >> request commit gate > >>> feature under review in the edk2-staging/edk2-ci > >> branch. This will be > >>> the only method to push patches to the edk2 repo in > >> the near future, > >>> and we want all current EDK II Maintainers to make > >> sure they know how > >>> to use this new process on the edk2-staging repo > >> before it is > >>> activated on the > >>> edk2 repo. > >>> > >>> Please perform the following steps: > >>> * Create a personal fork of the edk2-staging repo. > >> > >> Slight but relevant clarification: please create a > personal fork of > >> the edk2-staging repo *on GitHub.com*. > >> > >>> * Check out the edk2-ci branch from your personal > >>> fork of the edk2-staging repo > >>> * Create a new branch based on the edk2-ci branch > >>> * Edit the file SampleFile.txt in the root of this > >>> branch and add an Acked-by: <your email> tag to > >>> the end of this file. > >>> * Submit a pull request against the Tianocore > >>> edk2-staging/edk2-ci. Set the 'push' label so > >>> the change to SampleFile.txt will be committed > >>> if all checks pass. > >>> > >>> NOTE: Make sure you select the 'edk2-ci' branch. > >>> The default branch for the edk2-staging repo is > >>> the 'about' branch and the pull request will not > >>> work against the 'about' branch. > >>> > >>> * Verify that all checks pass and your change to > >>> SampleFile.txt was merged into the > >>> edk2-staging/edk2-ci branch. > >>> > >>> For those that prefer command line tools over a > WebUI, > >> the command > >>> line utility called 'hub' can be used to submit a > pull > >> request and > >>> check the status of a pull request. > >>> > >>> * https://github.com/github/hub > >>> * https://github.com/github/hub/releases > >>> * https://hub.github.com/hub.1.html > >> > >> I've gone through the above (except the personal > Acked- by tag) > >> earlier, > >> successfully: > >> > >> https://github.com/tianocore/edk2-staging/pull/99 > >> > >> Thanks! > >> Laszlo > > > > > > > > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-07 2:24 EDK II Maintainers please test the pull request commit gate Michael D Kinney 2019-11-07 11:00 ` [edk2-devel] " Laszlo Ersek @ 2019-11-08 14:49 ` Philippe Mathieu-Daudé 2019-11-08 17:10 ` Michael D Kinney 2019-11-11 5:42 ` Ni, Ray 2 siblings, 1 reply; 11+ messages in thread From: Philippe Mathieu-Daudé @ 2019-11-08 14:49 UTC (permalink / raw) To: michael.d.kinney; +Cc: devel Hi Michael, On 11/7/19 3:24 AM, Michael D Kinney wrote: > EDK II Maintainers, > > Please take a few minutes to test the GitHub pull > request commit gate feature under review in the > edk2-staging/edk2-ci branch. This will be the only > method to push patches to the edk2 repo in the near > future, and we want all current EDK II Maintainers to > make sure they know how to use this new process on > the edk2-staging repo before it is activated on the > edk2 repo. [...] Is it possible to use the CI gating scripts on an individual fork when working on a new feature, so if the CI system catches bugs we can fix them before bothering the mailing list and maintainers for review? Thanks, Phil. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-08 14:49 ` Philippe Mathieu-Daudé @ 2019-11-08 17:10 ` Michael D Kinney 2019-11-08 17:43 ` rebecca 0 siblings, 1 reply; 11+ messages in thread From: Michael D Kinney @ 2019-11-08 17:10 UTC (permalink / raw) To: Philippe Mathieu-Daudé, Kinney, Michael D; +Cc: devel@edk2.groups.io Phil, Yes. There are two methods available 1) You can run the CI tests on your local dev system. Fix issues locally and rerun as needed before sending patch review email. This will only perform build tests with your local compiler. 2) You can push a branch with changes to your personal fork of the edk2 repository (edk2-staging in the review period) and submit a pull request to the tianocore repo *without* the 'push' label set . This is considered a personal build. If all CI checks pass then the PR is auto closed with a comment on the PR. If the PR fails, then the PR is left open with comment on the PR. In the failure case, you can fix the issue on your local branch and do a forced push to your personal fork. GitHub sees the forced push and reruns the CI tests automatically. Today this runs build tests for VS2019 and GCC, so you get better coverage than local testing. Once your personal build passes, you can send patch review email and can even point to the PR for your personal build so reviewers and maintainers can view the CI results. NOTE: (1) does not send any public emails. (2) will send a public email when a comment or close action is performed on a PR to all GitHub users that are watching that repo. Best regards, Mike > -----Original Message----- > From: Philippe Mathieu-Daudé <philmd@redhat.com> > Sent: Friday, November 8, 2019 6:49 AM > To: Kinney, Michael D <michael.d.kinney@intel.com> > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] EDK II Maintainers please test > the pull request commit gate > > Hi Michael, > > On 11/7/19 3:24 AM, Michael D Kinney wrote: > > EDK II Maintainers, > > > > Please take a few minutes to test the GitHub pull > request commit gate > > feature under review in the edk2-staging/edk2-ci > branch. This will be > > the only method to push patches to the edk2 repo in > the near future, > > and we want all current EDK II Maintainers to make > sure they know how > > to use this new process on the edk2-staging repo > before it is > > activated on the > > edk2 repo. > [...] > > Is it possible to use the CI gating scripts on an > individual fork when working on a new feature, so if the > CI system catches bugs we can fix them before bothering > the mailing list and maintainers for review? > > Thanks, > > Phil. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [edk2-devel] EDK II Maintainers please test the pull request commit gate 2019-11-08 17:10 ` Michael D Kinney @ 2019-11-08 17:43 ` rebecca 0 siblings, 0 replies; 11+ messages in thread From: rebecca @ 2019-11-08 17:43 UTC (permalink / raw) To: devel, michael.d.kinney, Philippe Mathieu-Daudé On 11/8/19 10:10 AM, Michael D Kinney wrote: > 1) You can run the CI tests on your local dev system. > Fix issues locally and rerun as needed before sending > patch review email. This will only perform build > tests with your local compiler. > > 2) You can push a branch with changes to your personal > fork of the edk2 repository (edk2-staging in the > review period) and submit a pull request to the > tianocore repo *without* the 'push' label set . This > is considered a personal build. If all CI checks pass > then the PR is auto closed with a comment on the > PR. If the PR fails, then the PR is left open with > comment on the PR. In the failure case, you can fix > the issue on your local branch and do a forced > push to your personal fork. GitHub sees the forced > push and reruns the CI tests automatically. Today > this runs build tests for VS2019 and GCC, so you get > better coverage than local testing. Once your personal > build passes, you can send patch review email and can > even point to the PR for your personal build so > reviewers and maintainers can view the CI results. > > NOTE: (1) does not send any public emails. > (2) will send a public email when a comment or > close action is performed on a PR to all > GitHub users that are watching that repo.\ In addition, if there's interest I can set up my Jenkins system again, which would allow developers to run a Python script against their edk2 clone to submit builds on the build farm I have - which has Windows (VS2015, VS2017 and VS2019), Linux (GCC4.9, GCC5), and macOS (Clang) agents. Unfortunately using pull requests to submit personal CI builds seems a bit suboptimal to me. But perhaps that's just because I'm not used to using them. -- Rebecca Cran ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: EDK II Maintainers please test the pull request commit gate 2019-11-07 2:24 EDK II Maintainers please test the pull request commit gate Michael D Kinney 2019-11-07 11:00 ` [edk2-devel] " Laszlo Ersek 2019-11-08 14:49 ` Philippe Mathieu-Daudé @ 2019-11-11 5:42 ` Ni, Ray 2 siblings, 0 replies; 11+ messages in thread From: Ni, Ray @ 2019-11-11 5:42 UTC (permalink / raw) To: devel@edk2.groups.io, Kinney, Michael D Created https://github.com/tianocore/edk2-staging/pull/189 and it succeeded. (may not in the recommended way, from staging/cpu/remove_xd to staging/edk2-ci Instead of from personal/cpu/remove_xd to staging/edk2-ci.) > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > D Kinney > Sent: Thursday, November 7, 2019 10:24 AM > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com> > Subject: [edk2-devel] EDK II Maintainers please test the pull request commit > gate > > EDK II Maintainers, > > Please take a few minutes to test the GitHub pull request commit gate > feature under review in the edk2-staging/edk2-ci branch. This will be the > only method to push patches to the edk2 repo in the near future, and we > want all current EDK II Maintainers to make sure they know how to use this > new process on the edk2-staging repo before it is activated on the > edk2 repo. > > Please perform the following steps: > * Create a personal fork of the edk2-staging repo. > * Check out the edk2-ci branch from your personal > fork of the edk2-staging repo > * Create a new branch based on the edk2-ci branch > * Edit the file SampleFile.txt in the root of this > branch and add an Acked-by: <your email> tag to > the end of this file. > * Submit a pull request against the Tianocore > edk2-staging/edk2-ci. Set the 'push' label so > the change to SampleFile.txt will be committed > if all checks pass. > > NOTE: Make sure you select the 'edk2-ci' branch. > The default branch for the edk2-staging repo is > the 'about' branch and the pull request will not > work against the 'about' branch. > > * Verify that all checks pass and your change to > SampleFile.txt was merged into the > edk2-staging/edk2-ci branch. > > For those that prefer command line tools over a WebUI, the command line > utility called 'hub' can be used to submit a pull request and check the status > of a pull request. > > * https://github.com/github/hub > * https://github.com/github/hub/releases > * https://hub.github.com/hub.1.html > > Thanks, > > Mike > > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-11-11 5:42 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-11-07 2:24 EDK II Maintainers please test the pull request commit gate Michael D Kinney 2019-11-07 11:00 ` [edk2-devel] " Laszlo Ersek 2019-11-07 15:18 ` Liming Gao 2019-11-07 19:33 ` Michael D Kinney 2019-11-07 19:26 ` Michael D Kinney 2019-11-08 17:12 ` Laszlo Ersek 2019-11-08 17:21 ` Michael D Kinney 2019-11-08 14:49 ` Philippe Mathieu-Daudé 2019-11-08 17:10 ` Michael D Kinney 2019-11-08 17:43 ` rebecca 2019-11-11 5:42 ` Ni, Ray
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox