Re: [PATCH V4 7/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Tuesday, November 12, 2019 11:49 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [PATCH V4 7/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM
> and Die for type 17
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
> 
> Memory Device (Type 17):
> - SMBIOSCR00178: add new memory device type value (HBM) and new form
> factor value (Die)
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c       | 12
> ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index 8ed2bae4d3..16b75f2667 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> +++ c
> @@ -2423,6 +2423,10 @@ TABLE_ITEM  MemoryDeviceFormFactorTable[] = {
>    {
>      0x0F,
>      L"  FB-DIMM"
> +  },
> +  {
> +    MemoryFormFactorDie,
> +    L"  Die"
>    }
>  };
> 
> @@ -2538,6 +2542,14 @@ TABLE_ITEM  MemoryDeviceTypeTable[] = {
>    {
>      0x1F,
>      L"  Logical non-volatile device"
> +  },
> +  {
> +    MemoryTypeHBM,
> +    L"  HBM (High Bandwidth Memory)"
> +  },
> +  {
> +    MemoryTypeHBM2,
> +    L"  HBM2 (High Bandwidth Memory Generation 2)"
>    }
>  };
> 
> --
> 2.16.2.windows.1