From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by mx.groups.io with SMTP id smtpd.web09.7957.1573540331834484671
 for <devel@edk2.groups.io>;
 Mon, 11 Nov 2019 22:32:11 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
  by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 22:32:11 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.68,295,1569308400"; 
   d="scan'208";a="253449646"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by FMSMGA003.fm.intel.com with ESMTP; 11 Nov 2019 22:32:11 -0800
Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 11 Nov 2019 22:32:10 -0800
Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by
 FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 11 Nov 2019 22:32:10 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by
 SHSMSX108.ccr.corp.intel.com ([169.254.8.41]) with mapi id 14.03.0439.000;
 Tue, 12 Nov 2019 14:32:08 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [PATCH V4 7/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17
Thread-Topic: [PATCH V4 7/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM
 and Die for type 17
Thread-Index: AQHVmQwtKXhR9gCQwkSPYwodDAjJeqeHEt5w
Date: Tue, 12 Nov 2019 06:32:07 +0000
Deferred-Delivery: Tue, 12 Nov 2019 06:30:00 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C35A45E@SHSMSX104.ccr.corp.intel.com>
References: <20191112034900.11912-1-zhichao.gao@intel.com>
 <20191112034900.11912-8-zhichao.gao@intel.com>
In-Reply-To: <20191112034900.11912-8-zhichao.gao@intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Tuesday, November 12, 2019 11:49 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [PATCH V4 7/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM
> and Die for type 17
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2305
>=20
> Memory Device (Type 17):
> - SMBIOSCR00178: add new memory device type value (HBM) and new form
> factor value (Die)
>=20
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c       | 12
> ++++++++++++
>  1 file changed, 12 insertions(+)
>=20
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> index 8ed2bae4d3..16b75f2667 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> +++ c
> @@ -2423,6 +2423,10 @@ TABLE_ITEM  MemoryDeviceFormFactorTable[] =3D {
>    {
>      0x0F,
>      L"  FB-DIMM"
> +  },
> +  {
> +    MemoryFormFactorDie,
> +    L"  Die"
>    }
>  };
>=20
> @@ -2538,6 +2542,14 @@ TABLE_ITEM  MemoryDeviceTypeTable[] =3D {
>    {
>      0x1F,
>      L"  Logical non-volatile device"
> +  },
> +  {
> +    MemoryTypeHBM,
> +    L"  HBM (High Bandwidth Memory)"
> +  },
> +  {
> +    MemoryTypeHBM2,
> +    L"  HBM2 (High Bandwidth Memory Generation 2)"
>    }
>  };
>=20
> --
> 2.16.2.windows.1