From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.1888.1573612334148949999 for ; Tue, 12 Nov 2019 18:32:14 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 18:32:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,298,1569308400"; d="scan'208";a="207313841" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 12 Nov 2019 18:32:11 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 18:32:11 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 Nov 2019 18:32:11 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by shsmsx102.ccr.corp.intel.com ([169.254.2.108]) with mapi id 14.03.0439.000; Wed, 13 Nov 2019 10:32:08 +0800 From: "Ni, Ray" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" Subject: Re: [PATCH V5 5/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9 Thread-Topic: [PATCH V5 5/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9 Thread-Index: AQHVmcevpNopCgoLtUyBbfDEfwEvdqeIYLcw Date: Wed, 13 Nov 2019 02:32:08 +0000 Deferred-Delivery: Wed, 13 Nov 2019 02:30:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C35B6CD@SHSMSX104.ccr.corp.intel.com> References: <20191113021115.16888-1-zhichao.gao@intel.com> <20191113021115.16888-6-zhichao.gao@intel.com> In-Reply-To: <20191113021115.16888-6-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, November 13, 2019 10:11 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray ; > Chaganty, Rangasai V > Subject: [PATCH V5 5/8] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 > values for type 9 >=20 > From: "Gao, Zhichao" >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2305 >=20 > System Slots (Type 9): > - SMBIOSCR00184: add PCI Express Gen 4 values >=20 > Add the Smbios.h to use the MARCOs or enums. >=20 > Cc: Ray Ni > Cc: Sai Chaganty > Signed-off-by: Zhichao Gao > --- > .../SmbiosView/QueryTable.c | 26 ++++++++++++++++= +++++- > .../SmbiosView/QueryTable.h | 4 +++- > 2 files changed, 28 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > index fdb7a47d33..94d995bda1 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > @@ -2,7 +2,7 @@ > Build a table, each item is (Key, Info) pair. > And give a interface of query a string out of a table. >=20 > - Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2005 - 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -1523,6 +1523,30 @@ TABLE_ITEM SystemSlotTypeTable[] =3D { > { > 0xB6, > L"PCI Express Gen 3 X16" > + }, > + { > + SlotTypePciExpressGen4, > + L"PCI Express Gen 4" > + }, > + { > + SlotTypePciExpressGen4X1, > + L"PCI Express Gen 4 X1" > + }, > + { > + SlotTypePciExpressGen4X2, > + L"PCI Express Gen 4 X2" > + }, > + { > + SlotTypePciExpressGen4X4, > + L"PCI Express Gen 4 X4" > + }, > + { > + SlotTypePciExpressGen4X8, > + L"PCI Express Gen 4 X8" > + }, > + { > + SlotTypePciExpressGen4X16, > + L"PCI Express Gen 4 X16" > } > }; >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > h > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > h > index 60fb42c59c..756009b2f2 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > h > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > h > @@ -2,7 +2,7 @@ > Build a table, each item is (key, info) pair. > and give a interface of query a string out of a table. >=20 > - Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2005 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -10,6 +10,8 @@ > #ifndef _SMBIOS_QUERY_TABLE_H_ > #define _SMBIOS_QUERY_TABLE_H_ >=20 > +#include > + > #define QUERY_TABLE_UNFOUND 0xFF >=20 > typedef struct TABLE_ITEM { > -- > 2.16.2.windows.1