Re: [PATCH 1/3] MdePkg-UefiSpec.h: Add UEFI 2.8 RuntimeServicesSuppported definations

["Ni, Ray" <ray.ni@intel.com>]

Jeff,
I feel the BIT definitions can be together with the
RuntimeServicesSuppported variable.

But I found the EFI_OS_INDICATIONS_XXX macros are already in
UefiSpec.h.
So I am fine with that.

Reviewed-by: Ray Ni <ray.ni@intel.com>


> -----Original Message-----
> From: Jeff Brasen <jbrasen@nvidia.com>
> Sent: Saturday, November 16, 2019 1:43 AM
> To: edk2-devel@lists.01.org; devel@edk2.groups.io
> Cc: Jeff Brasen <jbrasen@nvidia.com>; Gao, Liming <liming.gao@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: [PATCH 1/3] MdePkg-UefiSpec.h: Add UEFI 2.8
> RuntimeServicesSuppported definations
> 
> Add bitmask values for the value of the RuntimeServicesSupported variable
> defined in the UEFI 2.8 specification. This is used to describe what services
> the platform supports while in runtime.
> 
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>  MdePkg/Include/Uefi/UefiSpec.h | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> b/MdePkg/Include/Uefi/UefiSpec.h index 444aa35..7e2b719 100644
> --- a/MdePkg/Include/Uefi/UefiSpec.h
> +++ b/MdePkg/Include/Uefi/UefiSpec.h
> @@ -1783,6 +1783,24 @@ EFI_STATUS
>  #define EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
> 0x0000000000000040
> 
>  //
> +// Bitmasks of supported runtime functions for RuntimeServicesSupported
> +variable //
> +#define EFI_RT_SUPPORTED_GET_TIME                           0x0001
> +#define EFI_RT_SUPPORTED_SET_TIME                           0x0002
> +#define EFI_RT_SUPPORTED_GET_WAKEUP_TIME                    0x0004
> +#define EFI_RT_SUPPORTED_SET_WAKEUP_TIME                    0x0008
> +#define EFI_RT_SUPPORTED_GET_VARIABLE                       0x0010
> +#define EFI_RT_SUPPORTED_GET_NEXT_VARIABLE_NAME             0x0020
> +#define EFI_RT_SUPPORTED_SET_VARIABLE                       0x0040
> +#define EFI_RT_SUPPORTED_SET_VIRTUAL_ADDRESS_MAP            0x0080
> +#define EFI_RT_SUPPORTED_CONVERT_POINTER                    0x0100
> +#define EFI_RT_SUPPORTED_GET_NEXT_HIGH_MONOTONIC_COUNT
> 0x0200
> +#define EFI_RT_SUPPORTED_RESET_SYSTEM                       0x0400
> +#define EFI_RT_SUPPORTED_UPDATE_CAPSULE                     0x0800
> +#define EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES         0x1000
> +#define EFI_RT_SUPPORTED_QUERY_VARIABLE_INFO                0x2000
> +
> +//
>  // EFI Runtime Services Table
>  //
>  #define EFI_SYSTEM_TABLE_SIGNATURE      SIGNATURE_64 ('I','B','I','
> ','S','Y','S','T')
> --
> 2.7.4