From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by mx.groups.io with SMTP id smtpd.web11.3423.1576133639897144390
 for <devel@edk2.groups.io>;
 Wed, 11 Dec 2019 22:54:00 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 22:53:59 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,304,1571727600"; 
   d="scan'208";a="207969664"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by orsmga008.jf.intel.com with ESMTP; 11 Dec 2019 22:53:59 -0800
Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 11 Dec 2019 22:53:58 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by
 SHSMSX108.ccr.corp.intel.com ([169.254.8.46]) with mapi id 14.03.0439.000;
 Thu, 12 Dec 2019 14:53:57 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Justen, Jordan L" <jordan.l.justen@intel.com>, Laszlo Ersek
	<lersek@redhat.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, "Kinney,
 Michael D" <michael.d.kinney@intel.com>, "Gao, Liming"
	<liming.gao@intel.com>, "Dong, Eric" <eric.dong@intel.com>, Brijesh Singh
	<brijesh.singh@amd.com>
Subject: Re: [RFC PATCH v3 22/43] UefiCpuPkg/CpuExceptionHandler: Add support for DR7 Read/Write NAE events
Thread-Topic: [RFC PATCH v3 22/43] UefiCpuPkg/CpuExceptionHandler: Add
 support for DR7 Read/Write NAE events
Thread-Index: AQHVn945INs3EQ1sjkiw/Ufd2xjeKae2LR6Q
Date: Thu, 12 Dec 2019 06:53:57 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C399A2E@SHSMSX104.ccr.corp.intel.com>
References: <cover.1574280425.git.thomas.lendacky@amd.com>
 <a94e704d716abe630b6ce2c7d7aebc4bf02f4ea1.1574280425.git.thomas.lendacky@amd.com>
In-Reply-To: <a94e704d716abe630b6ce2c7d7aebc4bf02f4ea1.1574280425.git.thomas.lendacky@amd.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjAwMjNhNGEtYzNhNC00ODlhLWE4MWItZDkxMDU5OTNjOGQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidmlnXC9lYTN2bU41NGVCdzdlMStRS1RkT2tvcFo4bzFKblhQakRqMFZaV1dBOGsrK0ZyekRCTm1zUUNjRzIyK2cifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

>=20
>  ;; UINT64  Dr0, Dr1, Dr2, Dr3, Dr6, Dr7;
> +    cmp     qword [rbp + 8], 29

Can you define a macro instead of using 29?

> +    je      VcDebugRegs          ; For SEV-ES (#VC) Debug registers igno=
red