From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.4196.1576486234026635612 for ; Mon, 16 Dec 2019 00:50:34 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 00:50:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,321,1571727600"; d="scan'208";a="416368356" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 16 Dec 2019 00:50:33 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Dec 2019 00:50:33 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Dec 2019 00:50:32 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.164]) with mapi id 14.03.0439.000; Mon, 16 Dec 2019 16:50:30 +0800 From: "Ni, Ray" To: "Kubacki, Michael A" CC: "Desimone, Nathaniel L" , "devel@edk2.groups.io" , "Chiu, Chasel" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids Thread-Index: AQHVsh5m2r1Qkb4CCUK9r7wZYKDwg6e7dsUAgAD+gJA= Date: Mon, 16 Dec 2019 08:50:29 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C39ECCC@SHSMSX104.ccr.corp.intel.com> References: <20c55746e3b8e848cfff7b17b41a26207383d7e1.1576282834.git.prince.agyeman@intel.com> <3C3EFB470A303B4AB093197B6777CCEC505CA725@PGSMSX111.gar.corp.intel.com> In-Reply-To: <3C3EFB470A303B4AB093197B6777CCEC505CA725@PGSMSX111.gar.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Using event for callbacks has a limitation: The event callback has to run a= t TPL >=3D TPL_CALLBACK. Some of the services like gBS->LoadImage()/StartImage(), SimpleTextIn->Rea= dKeyStroke(), FormBrowser->SendForm() can ONLY be called at TPL_APPLICATION. So those services cannot be called from the event callback. Is that ok to the min-platform? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Monday, December 16, 2019 9:32 AM > To: Agyeman, Prince ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Desimone, Nathanie= l > L > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: > Add BDS Hook Point Guids >=20 >=20 > Reviewed-by: Chasel Chiu >=20 > > -----Original Message----- > > From: Agyeman, Prince > > Sent: Saturday, December 14, 2019 9:32 AM > > To: devel@edk2.groups.io > > Cc: Kubacki, Michael A ; Chiu, Chasel > > ; Desimone, Nathaniel L > > > > Subject: [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook > > Point Guids > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 > > > > Added BDS hook point guids as defined in the Minimum Platform > > specification. These GUIDs shall be used in the identification of thre= e of the > > BDS hook point event groups. > > > > These event groups are Before Console After Trusted, Before Console > Before > > End Of Dxe and After Console Ready Before BootOption events. > > > > See https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specificatio= n, > > under Appendix A.3 BDS Hook Points, for more details > > > > Cc: Michael Kubacki > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > > > Signed-off-by: Prince Agyeman > > --- > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > index 7f74ac9380..5bec4eee3a 100644 > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > @@ -46,6 +46,11 @@ > > gDefaultDataFileGuid =3D {0x1ae42876, 0x008f, 0x4161, > > {0xb2, 0xb7, 0x1c, 0x0d, 0x15, 0xc5, 0xef, 0x43}} > > gDefaultDataOptSizeFileGuid =3D {0x003e7b41, 0x98a2, 0x4be2, > > {0xb2, 0x7a, 0x6c, 0x30, 0xc7, 0x65, 0x52, 0x25}} > > > > + # BDS Hook point event Guids > > + gBdsEventBeforeConsoleAfterTrustedConsoleGuid =3D {0x51e49ff5, > > 0x28a9, 0x4159, { 0xac, 0x8a, 0xb8, 0xc4, 0x88, 0xa7, 0xfd, 0xee}} > > + gBdsEventBeforeConsoleBeforeEndOfDxeGuid =3D {0xfcf26e41, > > 0xbda6, 0x4633, { 0xb5, 0x73, 0xd4, 0xb8, 0x0e, 0x6d, 0xd0, 0x78}} > > + gBdsEventAfterConsoleReadyBeforeBootOptionGuid =3D {0x8eb3d5dc, > > 0xf4e7, > > + 0x4b57, { 0xa9, 0xe7, 0x27, 0x39, 0x10, 0xf2, 0x18, 0x9f}} > > + > > [LibraryClasses] > > > > PeiLib|Include/Library/PeiLib.h > > -- > > 2.19.1.windows.1 >=20 >=20 >=20