From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.4480.1576627909778285909 for ; Tue, 17 Dec 2019 16:11:50 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 16:11:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="227680021" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 17 Dec 2019 16:11:48 -0800 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 16:11:48 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 16:11:48 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.71]) with mapi id 14.03.0439.000; Wed, 18 Dec 2019 08:11:45 +0800 From: "Ni, Ray" To: "Kubacki, Michael A" CC: "Desimone, Nathaniel L" , "devel@edk2.groups.io" , "Chiu, Chasel" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids Thread-Index: AQHVsh5m2r1Qkb4CCUK9r7wZYKDwg6e7dsUAgAD+gJCAAgwhgIAAiHaQ Date: Wed, 18 Dec 2019 00:11:45 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A0FED@SHSMSX104.ccr.corp.intel.com> References: <20c55746e3b8e848cfff7b17b41a26207383d7e1.1576282834.git.prince.agyeman@intel.com> <3C3EFB470A303B4AB093197B6777CCEC505CA725@PGSMSX111.gar.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C39ECCC@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2M0NGIwZTYtYTZmNC00ODIyLWJmNTMtMzNhNTMzYjVlYWEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMmJmUjBQYkFNQ0dNaWpCem95RjcrRlE3TVwvbGY4aUtEUU5VRVpIYmo2Ym12eGFmbnh4OElzSFZTWVdkeVVNZU8ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Michael, I had misunderstanding earlier. Thanks for the explanation. Thanks, Ray > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, December 18, 2019 7:58 AM > To: Ni, Ray > Cc: Desimone, Nathaniel L ; devel@edk2.g= roups.io; Chiu, Chasel > ; Agyeman, Prince > Subject: RE: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg:= Add BDS Hook Point Guids >=20 > Hi Ray, >=20 > There could be usage of SimpleTextIn->ReadKeyStroke () in PlatformBootMa= nagerWaitCallback () and > PlatformBootManagerUnableToBoot (). The PlatformBootManagerLib instance = introduced in MinPlatformPkg simply > forwards those calls to a library instance of BoardBootManagerLib implem= ented in the board package so they will still be > invoked at TPL_APPLICATION. >=20 > A specific use case that requires TPL_APPLICATION (the restriction is re= latively minimal) has not been identified in the > analysis of use cases that led to the event hook points introduced in Pl= atformBootManagerLib. >=20 > Thanks, > Michael >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Monday, December 16, 2019 12:50 AM > > To: Kubacki, Michael A > > Cc: Desimone, Nathaniel L ; > > devel@edk2.groups.io; Chiu, Chasel ; Agyeman, > > Prince > > Subject: RE: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPk= g: > > Add BDS Hook Point Guids > > > > Using event for callbacks has a limitation: The event callback has to = run at TPL > > >=3D TPL_CALLBACK. > > > > Some of the services like gBS->LoadImage()/StartImage(), SimpleTextIn- > > >ReadKeyStroke(), > > FormBrowser->SendForm() can ONLY be called at TPL_APPLICATION. > > So those services cannot be called from the event callback. > > > > Is that ok to the min-platform? > > > > Thanks, > > Ray > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Chiu, > > > Chasel > > > Sent: Monday, December 16, 2019 9:32 AM > > > To: Agyeman, Prince ; devel@edk2.groups.io > > > Cc: Kubacki, Michael A ; Desimone, > > > Nathaniel L > > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatform= Pkg: > > > Add BDS Hook Point Guids > > > > > > > > > Reviewed-by: Chasel Chiu > > > > > > > -----Original Message----- > > > > From: Agyeman, Prince > > > > Sent: Saturday, December 14, 2019 9:32 AM > > > > To: devel@edk2.groups.io > > > > Cc: Kubacki, Michael A ; Chiu, Chasel > > > > ; Desimone, Nathaniel L > > > > > > > > Subject: [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Ho= ok > > > > Point Guids > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 > > > > > > > > Added BDS hook point guids as defined in the Minimum Platform > > > > specification. These GUIDs shall be used in the identification of > > > > three of the BDS hook point event groups. > > > > > > > > These event groups are Before Console After Trusted, Before Consol= e > > > Before > > > > End Of Dxe and After Console Ready Before BootOption events. > > > > > > > > See > > > > https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specificatio= n, > > > > under Appendix A.3 BDS Hook Points, for more details > > > > > > > > Cc: Michael Kubacki > > > > Cc: Chasel Chiu > > > > Cc: Nate DeSimone > > > > > > > > Signed-off-by: Prince Agyeman > > > > --- > > > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > > index 7f74ac9380..5bec4eee3a 100644 > > > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > > @@ -46,6 +46,11 @@ > > > > gDefaultDataFileGuid =3D {0x1ae42876, 0x008f, 0x41= 61, > > > > {0xb2, 0xb7, 0x1c, 0x0d, 0x15, 0xc5, 0xef, 0x43}} > > > > gDefaultDataOptSizeFileGuid =3D {0x003e7b41, 0x98a2, 0x4b= e2, > > > > {0xb2, 0x7a, 0x6c, 0x30, 0xc7, 0x65, 0x52, 0x25}} > > > > > > > > + # BDS Hook point event Guids > > > > + gBdsEventBeforeConsoleAfterTrustedConsoleGuid =3D {0x51e49ff5, > > > > 0x28a9, 0x4159, { 0xac, 0x8a, 0xb8, 0xc4, 0x88, 0xa7, 0xfd, 0xee}} > > > > + gBdsEventBeforeConsoleBeforeEndOfDxeGuid =3D {0xfcf26e41, > > > > 0xbda6, 0x4633, { 0xb5, 0x73, 0xd4, 0xb8, 0x0e, 0x6d, 0xd0, 0x78}} > > > > + gBdsEventAfterConsoleReadyBeforeBootOptionGuid =3D {0x8eb3d5dc, > > > > 0xf4e7, > > > > + 0x4b57, { 0xa9, 0xe7, 0x27, 0x39, 0x10, 0xf2, 0x18, 0x9f}} > > > > + > > > > [LibraryClasses] > > > > > > > > PeiLib|Include/Library/PeiLib.h > > > > -- > > > > 2.19.1.windows.1 > > > > > > > > >=20 > > >=20