From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by mx.groups.io with SMTP id smtpd.web10.4423.1576719270355632989
 for <devel@edk2.groups.io>;
 Wed, 18 Dec 2019 17:34:30 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 17:34:29 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; 
   d="scan'208";a="218330835"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by orsmga003.jf.intel.com with ESMTP; 18 Dec 2019 17:34:29 -0800
Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 18 Dec 2019 17:34:29 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 18 Dec 2019 17:34:28 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.29]) with mapi id 14.03.0439.000;
 Thu, 19 Dec 2019 09:34:26 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "Javeed, Ashraf" <ashraf.javeed@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12] PciBusDxe: Separation of the PCI device registration and start
Thread-Topic: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/12]
 PciBusDxe: Separation of the PCI device registration and start
Thread-Index: AQHVmdHzr5znFu2yV0yGSxmjusHFM6e863UQgABsRQCAA4zWsA==
Date: Thu, 19 Dec 2019 01:34:25 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A2614@SHSMSX104.ccr.corp.intel.com>
References: <20191101150952.3340-1-ashraf.javeed@intel.com>
 <15D3127A98E21087.7420@groups.io>
 <95C5C2B113DE604FB208120C742E982457917197@BGSMSX101.gar.corp.intel.com>
 <734D49CCEBEEF84792F5B80ED585239D5C39FE01@SHSMSX104.ccr.corp.intel.com>
 <95C5C2B113DE604FB208120C742E98245797B7EF@BGSMSX101.gar.corp.intel.com>
In-Reply-To: <95C5C2B113DE604FB208120C742E98245797B7EF@BGSMSX101.gar.corp.intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> >
> > 2 minor comments:
> > 1. StartPciRootPortsOnBridge()
> >      Can it be renamed to EnablePciDevicesOnBridge()?
> >      Because it basically calls PciIo.Attribute() to enable the devices=
. And I am
> not
> > sure the enable only applies to PCI root ports. There could be PCI devi=
ces
> behind
> > P2P bridge.
> It enables only Type 1 PCI devices (Root Port, PCIe-to-PCI Bridge, PCIe s=
witch
> upstream/downstream ports), and no endpoint (Type 0) devices.

I see. Then how about EnablePciBridges()?