From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.5846.1576820991372841255 for ; Thu, 19 Dec 2019 21:49:51 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2019 21:49:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,334,1571727600"; d="scan'208";a="390774293" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 19 Dec 2019 21:49:50 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 19 Dec 2019 21:49:50 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 19 Dec 2019 21:49:49 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Fri, 20 Dec 2019 13:49:48 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Kinney, Michael D" , "Gao, Liming" , Vitaly Cheptsov Subject: Re: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate the lib instances Thread-Topic: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate the lib instances Thread-Index: AQHVtUhaZqQss9EcQUyyXiVe/Bzo16fCh0NQ Date: Fri, 20 Dec 2019 05:49:48 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A3F54@SHSMSX104.ccr.corp.intel.com> References: <20191218021036.23072-1-zhichao.gao@intel.com> In-Reply-To: <20191218021036.23072-1-zhichao.gao@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhichao, \MdePkg\Library\UefiDevicePathLibDevicePathProtocol\ contains the version = that hard-depends on the protocol. I don't think you need to add another version. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Wednesday, December 18, 2019 10:11 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Vitaly Cheptsov > Subject: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate > the lib instances >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2298 >=20 > The UefiDevicePathLibOptionalDevicePathProtocolConstructor's > implementation > isn't match with its instance name. > Remove the ASSERT and depex of the gEfiDevicePathUtilitiesProtocolGuid > because of "Optional". >=20 > Add a mandatory instance to force using the DevicePathUtilities, > DevicePathToText and DevicePathFromText protocol with the ASSERT > and depex. >=20 > V2: > The optional lib instance's construction should return success all the > time. > Change the desciption of the optional lib uni file. > Change the copyright date of the mandatory one's uni file. >=20 > V3: > Remove the Status variable in > UefiDevicePathLibOptionalDevicePathProtocolConstructor. > The Status would cause GCC build fail because the variable is initialize= d but > not used. > Since it is useless for the constructor, directly remove it. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Vitaly Cheptsov > Signed-off-by: Zhichao Gao >=20 > Zhichao Gao (2): > MdePkg/UefiDevicePathLib: Separate the device path lib > MdePkg/dsc: Add UefiDevicePathLibMandatoryDevicePathProtocol for > build >=20 > ...DevicePathLibMandatoryDevicePathProtocol.c | 469 > ++++++++++++++++++ > ...vicePathLibMandatoryDevicePathProtocol.inf | 86 ++++ > ...vicePathLibMandatoryDevicePathProtocol.uni | 18 + > ...iDevicePathLibOptionalDevicePathProtocol.c | 21 +- > ...evicePathLibOptionalDevicePathProtocol.inf | 5 +- > ...evicePathLibOptionalDevicePathProtocol.uni | 6 +- > MdePkg/MdePkg.dsc | 3 +- > 7 files changed, 587 insertions(+), 21 deletions(-) > create mode 100644 > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePat > hProtocol.c > create mode 100644 > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePat > hProtocol.inf > create mode 100644 > MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePat > hProtocol.uni >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20