From: "Ni, Ray" <ray.ni@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH] edksetup.bat: Simplify the step to use CLANGPDB
Date: Fri, 20 Dec 2019 07:40:55 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A426F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191220073512.147180-1-zhiguang.liu@intel.com>
> +:check_CLANGPDB
1. Would be great if there is comment to explain why "n" is set to CLANG_HOST_BIN.
> +@set CLANG_HOST_BIN=n
> +if not defined CLANG_BIN (
> + @echo.
> + @echo !!! WARNING !!! CLANG_BIN environment variable is not set
> + @if exist "C:\Program Files\LLVM\bin\clang.exe" (
> + @set CLANG_BIN=C:\Program Files\LLVM\bin\
> + @echo Found LLVM, setting the environment variable to C:\Program
> Files\LLVM\bin\
2. How about "Found LLVM, setting CLANG_BIN environment variable to C:\Program Files\LLVM\bin\."?
prev parent reply other threads:[~2019-12-20 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 7:35 [PATCH] edksetup.bat: Simplify the step to use CLANGPDB Zhiguang Liu
2019-12-20 7:40 ` Ni, Ray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C3A426F@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox