From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by mx.groups.io with SMTP id smtpd.web11.6241.1576827659348405946
 for <devel@edk2.groups.io>;
 Thu, 19 Dec 2019 23:40:59 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2019 23:40:58 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,335,1571727600"; 
   d="scan'208";a="218419133"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
  by orsmga006.jf.intel.com with ESMTP; 19 Dec 2019 23:40:58 -0800
Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 19 Dec 2019 23:40:58 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 19 Dec 2019 23:40:58 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.29]) with mapi id 14.03.0439.000;
 Fri, 20 Dec 2019 15:40:56 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Gao, Liming" <liming.gao@intel.com>, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH] edksetup.bat: Simplify the step to use CLANGPDB
Thread-Topic: [PATCH] edksetup.bat: Simplify the step to use CLANGPDB
Thread-Index: AQHVtwgUu2N7rGxCvkqeVfTbo+k36KfCorGA
Date: Fri, 20 Dec 2019 07:40:55 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A426F@SHSMSX104.ccr.corp.intel.com>
References: <20191220073512.147180-1-zhiguang.liu@intel.com>
In-Reply-To: <20191220073512.147180-1-zhiguang.liu@intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> +:check_CLANGPDB

1. Would be great if there is comment to explain why "n" is set to CLANG_HO=
ST_BIN.

> +@set CLANG_HOST_BIN=3Dn
> +if not defined CLANG_BIN (
> +    @echo.
> +    @echo !!! WARNING !!! CLANG_BIN environment variable is not set
> +    @if exist "C:\Program Files\LLVM\bin\clang.exe" (
> +        @set CLANG_BIN=3DC:\Program Files\LLVM\bin\
> +        @echo   Found LLVM, setting the environment variable to C:\Progr=
am
> Files\LLVM\bin\

2. How about "Found LLVM, setting CLANG_BIN environment variable to C:\Prog=
ram Files\LLVM\bin\."?