From: "Ni, Ray" <ray.ni@intel.com>
To: Ashish Singhal <ashishsingha@nvidia.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol
Date: Mon, 23 Dec 2019 01:46:32 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A88B2@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <c942b3f58b04998a194a8643b947e8fb6bbf9b33.1576696105.git.ashishsingha@nvidia.com>
+ typedef struct _PLATFORM_BOOT_MANAGER_PROTOCOL PLATFORM_BOOT_MANAGER_PROTOCOL;
Ashish,
Please add EDKII_ prefix to the protocol structure as well: EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL.
I see you already added the prefix to the GUID name.
Thanks,
Ray
next prev parent reply other threads:[~2019-12-23 1:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 19:10 [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol Ashish Singhal
2019-12-19 1:59 ` Ni, Ray
2019-12-19 14:22 ` [edk2-devel] " Wang, Sunny (HPS SW)
2019-12-19 16:38 ` Ashish Singhal
2019-12-20 11:28 ` Wang, Sunny (HPS SW)
2019-12-24 2:40 ` Ni, Ray
2019-12-24 4:37 ` Wang, Sunny (HPS SW)
2019-12-24 4:48 ` Ashish Singhal
2020-02-06 9:08 ` Wang, Sunny (HPS SW)
2019-12-23 1:46 ` Ni, Ray [this message]
2019-12-23 2:08 ` Ashish Singhal
2019-12-23 2:27 ` Ashish Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C3A88B2@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox