From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by mx.groups.io with SMTP id smtpd.web09.5355.1577065596789406728
 for <devel@edk2.groups.io>;
 Sun, 22 Dec 2019 17:46:36 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2019 17:46:36 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,346,1571727600"; 
   d="scan'208";a="207123524"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
  by orsmga007.jf.intel.com with ESMTP; 22 Dec 2019 17:46:36 -0800
Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 22 Dec 2019 17:46:35 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 22 Dec 2019 17:46:35 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.214]) with mapi id 14.03.0439.000;
 Mon, 23 Dec 2019 09:46:33 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: Ashish Singhal <ashishsingha@nvidia.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>, "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A"
	<hao.a.wu@intel.com>, "Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol
Thread-Topic: [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager
 Protocol
Thread-Index: AQHVtdbjDTqRtxi1sUCba08r6L+ncKfG+Mcw
Date: Mon, 23 Dec 2019 01:46:32 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A88B2@SHSMSX104.ccr.corp.intel.com>
References: <c942b3f58b04998a194a8643b947e8fb6bbf9b33.1576696105.git.ashishsingha@nvidia.com>
In-Reply-To: <c942b3f58b04998a194a8643b947e8fb6bbf9b33.1576696105.git.ashishsingha@nvidia.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

+ typedef struct _PLATFORM_BOOT_MANAGER_PROTOCOL PLATFORM_BOOT_MANAGER_PROT=
OCOL;

Ashish,
Please add EDKII_ prefix to the protocol structure as well: EDKII_PLATFORM_=
BOOT_MANAGER_PROTOCOL.
I see you already added the prefix to the GUID name.

Thanks,
Ray