From: "Ni, Ray" <ray.ni@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG definition.
Date: Mon, 23 Dec 2019 01:59:51 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A8977@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191221070743.10720-1-jiewen.yao@intel.com>
>
> - PcrIndex = EDKII_DEVICE_MEASUREMENT_COMPONENT_PCR_INDEX;
> + PcrIndex = 2;
Jiewen, PcrIndex assignment is using magic value 2 here.
I am ok with this magic value. Can you please add comment to say that this
PCR is a device measurement component PCR?
With that, Reviewed-by: Ray Ni <ray.ni@intel.com>
Thanks,
Ray
next prev parent reply other threads:[~2019-12-23 1:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 7:07 [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG definition Yao, Jiewen
2019-12-23 1:59 ` Ni, Ray [this message]
2019-12-23 5:35 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C3A8977@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox