From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by mx.groups.io with SMTP id smtpd.web09.5459.1577066395132743886
 for <devel@edk2.groups.io>;
 Sun, 22 Dec 2019 17:59:55 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2019 17:59:54 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,346,1571727600"; 
   d="scan'208";a="366922314"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by orsmga004.jf.intel.com with ESMTP; 22 Dec 2019 17:59:54 -0800
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 22 Dec 2019 17:59:54 -0800
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Sun, 22 Dec 2019 17:59:54 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000;
 Mon, 23 Dec 2019 09:59:51 +0800
From: "Ni, Ray" <ray.ni@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG definition.
Thread-Topic: [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG
 definition.
Thread-Index: AQHVt81gu5WDhddCqUe4XUX5e6fv96fG+JMA
Date: Mon, 23 Dec 2019 01:59:51 +0000
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A8977@SHSMSX104.ccr.corp.intel.com>
References: <20191221070743.10720-1-jiewen.yao@intel.com>
In-Reply-To: <20191221070743.10720-1-jiewen.yao@intel.com>
Accept-Language: en-US, zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: ray.ni@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

>=20
> -  PcrIndex =3D EDKII_DEVICE_MEASUREMENT_COMPONENT_PCR_INDEX;
> +  PcrIndex =3D 2;

Jiewen, PcrIndex assignment is using magic value 2 here.
I am ok with this magic value. Can you please add comment to say that this
PCR is a device measurement component PCR?

With that, Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray