From: "Ni, Ray" <ray.ni@intel.com>
To: "Wang, Sunny (HPS SW)" <sunnywang@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"ashishsingha@nvidia.com" <ashishsingha@nvidia.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"'Andrew Fish (afish@apple.com)'" <afish@apple.com>
Cc: "Spottswood, Jason" <jason.spottswood@hpe.com>
Subject: Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol
Date: Tue, 24 Dec 2019 02:40:13 +0000 [thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A9D96@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <DF4PR8401MB130776228820A01CD5BE2159A82D0@DF4PR8401MB1307.NAMPRD84.PROD.OUTLOOK.COM>
> -----Original Message-----
> From: Wang, Sunny (HPS SW) <sunnywang@hpe.com>
> Sent: Friday, December 20, 2019 7:29 PM
> To: devel@edk2.groups.io; ashishsingha@nvidia.com; Ni, Ray
> <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; 'Andrew Fish (afish@apple.com)'
> <afish@apple.com>
> Cc: Spottswood, Jason <jason.spottswood@hpe.com>; Wang, Sunny (HPS
> SW) <sunnywang@hpe.com>
> Subject: RE: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform
> Boot Manager Protocol
>
> Good point. The way you used is more robust. It can cover a mistake in
> function's error handling. Thanks for clarifying this, Ashish.
>
> In addition, the other naming suggestion just comes to mind. How about we
> rename the function to a more generic one (based on location) like
> AfterEnumerateBootOptions or a more specific one like
> RefreshEnumeratedBootOptions? In the future, we may add the other hook
> function in the EfiBootManagerRefreshAllBootOption to deal with the boot
> options that are not created by BmEnumerateBootOptions. In this case (two
> hook functions in EfiBootManagerRefreshAllBootOption), the original
> function name "RefreshAllBootOptions" may cause some confusion.
Sunny,
What else feasibility do you think platform may require in future but this
RefreshAllBootOptions cannot support?
Thanks,
Ray
next prev parent reply other threads:[~2019-12-24 2:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 19:10 [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol Ashish Singhal
2019-12-19 1:59 ` Ni, Ray
2019-12-19 14:22 ` [edk2-devel] " Wang, Sunny (HPS SW)
2019-12-19 16:38 ` Ashish Singhal
2019-12-20 11:28 ` Wang, Sunny (HPS SW)
2019-12-24 2:40 ` Ni, Ray [this message]
2019-12-24 4:37 ` Wang, Sunny (HPS SW)
2019-12-24 4:48 ` Ashish Singhal
2020-02-06 9:08 ` Wang, Sunny (HPS SW)
2019-12-23 1:46 ` Ni, Ray
2019-12-23 2:08 ` Ashish Singhal
2019-12-23 2:27 ` Ashish Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C3A9D96@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox