public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: Ashish Singhal <ashishsingha@nvidia.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	"Gao, Zhichao" <zhichao.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"afish@apple.com" <afish@apple.com>,
	"Wang, Sunny (HPS SW)" <sunnywang@hpe.com>
Subject: Re: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol
Date: Tue, 24 Dec 2019 03:33:57 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A9E4E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <DM6PR12MB3324C4BE488D3F584BAB40D9BA290@DM6PR12MB3324.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2279 bytes --]

Sunny had one comment regarding the API name and I replied.
Let's wait for Sunny's further comments as well.

Thanks,
Ray

From: Ashish Singhal <ashishsingha@nvidia.com>
Sent: Tuesday, December 24, 2019 11:00 AM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com; Wang, Sunny (HPS SW) <sunnywang@hpe.com>
Subject: Re: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

Hi Ray,

Patch 7 has been submitted. Please let me know if there are any other changes needed. I would wait for your patch acceptance email.

Thanks
Ashish
________________________________
From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Sent: Monday, December 23, 2019 7:38 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Ashish Singhal <ashishsingha@nvidia.com<mailto:ashishsingha@nvidia.com>>; Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; Wu, Hao A <hao.a.wu@intel.com<mailto:hao.a.wu@intel.com>>; Gao, Zhichao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; afish@apple.com<mailto:afish@apple.com> <afish@apple.com<mailto:afish@apple.com>>; Wang, Sunny (HPS SW) <sunnywang@hpe.com<mailto:sunnywang@hpe.com>>
Subject: RE: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

External email: Use caution opening links or attachments


> +(EFIAPI *REFRESH_ALL_BOOT_OPTIONS) (

I recommend to rename it to "PLATFORM_BOOT_MANAGER_REFRESH_ALL_BOOT_OPTIONS" to avoid
future name confliction with other protocols.
With that, Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
________________________________
This email message is for the sole use of the intended recipient(s) and may contain confidential information.  Any unauthorized review, use, disclosure or distribution is prohibited.  If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
________________________________

[-- Attachment #2: Type: text/html, Size: 6497 bytes --]

      reply	other threads:[~2019-12-24  3:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23  2:26 [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol Ashish Singhal
2019-12-24  2:05 ` Ashish Singhal
2019-12-24  2:38 ` [edk2-devel] " Ni, Ray
2019-12-24  2:59   ` Ashish Singhal
2019-12-24  3:33     ` Ni, Ray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C3A9E4E@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox