From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.1240.1577158441165926304 for ; Mon, 23 Dec 2019 19:34:01 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Dec 2019 19:34:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,350,1571727600"; d="scan'208,217";a="417447420" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 23 Dec 2019 19:34:00 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Dec 2019 19:34:00 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Dec 2019 19:34:00 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by shsmsx102.ccr.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0439.000; Tue, 24 Dec 2019 11:33:58 +0800 From: "Ni, Ray" To: Ashish Singhal , "devel@edk2.groups.io" , "Wang, Jian J" , "Wu, Hao A" , "Gao, Zhichao" , "Kinney, Michael D" , "afish@apple.com" , "Wang, Sunny (HPS SW)" Subject: Re: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol Thread-Topic: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol Thread-Index: AQHVuThnjZJj+FRBpEO35BcsztNRJ6fIkqbA//+BOoCAAI70IA== Date: Tue, 24 Dec 2019 03:33:57 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3A9E4E@SHSMSX104.ccr.corp.intel.com> References: <99d69ff17a4ca86b23a889b9ac84832d7f7a13b1.1577067900.git.ashishsingha@nvidia.com>,<734D49CCEBEEF84792F5B80ED585239D5C3A9D6D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_734D49CCEBEEF84792F5B80ED585239D5C3A9E4ESHSMSX104ccrcor_" --_000_734D49CCEBEEF84792F5B80ED585239D5C3A9E4ESHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sunny had one comment regarding the API name and I replied. Let's wait for Sunny's further comments as well. Thanks, Ray From: Ashish Singhal Sent: Tuesday, December 24, 2019 11:00 AM To: Ni, Ray ; devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A ; Gao, Zhichao ; Kinney, Michael D ; afish@apple.com= ; Wang, Sunny (HPS SW) Subject: Re: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot M= anager Protocol Hi Ray, Patch 7 has been submitted. Please let me know if there are any other chang= es needed. I would wait for your patch acceptance email. Thanks Ashish ________________________________ From: Ni, Ray > Sent: Monday, December 23, 2019 7:38 PM To: devel@edk2.groups.io >; Ashish Singhal >; Wang, Jian J >; Wu, Hao A >; Gao, Zhichao >;= Kinney, Michael D >; afish@apple.com >; Wang, Sunny (HPS SW) > Subject: RE: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot M= anager Protocol External email: Use caution opening links or attachments > +(EFIAPI *REFRESH_ALL_BOOT_OPTIONS) ( I recommend to rename it to "PLATFORM_BOOT_MANAGER_REFRESH_ALL_BOOT_OPTIONS= " to avoid future name confliction with other protocols. With that, Reviewed-by: Ray Ni > ________________________________ This email message is for the sole use of the intended recipient(s) and may= contain confidential information. Any unauthorized review, use, disclosur= e or distribution is prohibited. If you are not the intended recipient, pl= ease contact the sender by reply email and destroy all copies of the origin= al message. ________________________________ --_000_734D49CCEBEEF84792F5B80ED585239D5C3A9E4ESHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Sunny had one comment regarding the API name and I r= eplied.

Let’s wait for Sunny’s further comments = as well.

 

Thanks,

Ray

 

From: Ashish Singhal <ashishsingha@nvidia.= com>
Sent: Tuesday, December 24, 2019 11:00 AM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Wang, Ji= an J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; G= ao, Zhichao <zhichao.gao@intel.com>; Kinney, Michael D <michael.d.= kinney@intel.com>; afish@apple.com; Wang, Sunny (HPS SW) <sunnywang@h= pe.com>
Subject: Re: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform= Boot Manager Protocol

 

Hi Ray,=

&n= bsp;

Patch 7= has been submitted. Please let me know if there are any other changes need= ed. I would wait for your patch acceptance email.

&n= bsp;

Thanks<= o:p>

Ashish<= o:p>

From: Ni, Ray <ray= .ni@intel.com>
Sent: Monday, December 23, 2019 7:38 PM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; = Ashish Singhal <ashishsingha@= nvidia.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com= >; Gao, Zhichao <zhichao.gao= @intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com <afish@apple.com>; Wang, Sunny (HPS SW) <sunnywang@hpe.com>
Subject: RE: [edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform= Boot Manager Protocol

 

External email: Use caution opening links or attachm= ents


> +(EFIAPI *REFRESH_ALL_BOOT_OPTIONS) (

I recommend to rename it to "PLATFORM_BOOT_MANAGER_REFRESH_ALL_BOOT_OP= TIONS" to avoid
future name confliction with other protocols.
With that, Reviewed-by: Ray Ni <ray.= ni@intel.com>

This email message is for the sole use of the intend= ed recipient(s) and may contain confidential information.  Any unautho= rized review, use, disclosure or distribution is prohibited.  If you a= re not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. =

--_000_734D49CCEBEEF84792F5B80ED585239D5C3A9E4ESHSMSX104ccrcor_--