Re: Anyone successfully enabled clangd in edk2 code?

Re: Anyone successfully enabled clangd in edk2 code?

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

https://clang.llvm.org/extra/clangd/

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
Sent: Tuesday, December 24, 2019 4:14 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

All,
I am interested in using clangd to support symbolic navigation in Visual Studio Code.
But since EDKII doesn't have a master makefile, I am not sure how to enable clangd.
Anyone tried that recently?

Thanks,
Ray


[-- Attachment #2: Type: text/html, Size: 3421 bytes --]

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

[Tomas Pilar (tpilar)]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

I don't know about clangd but I am successfully using the vscode intellisense with EDKII including the multiple workspaces.

It took some time to configure things with paths and includes to make it work correctly but the only problem I have at the moment is to get it to use the correct AutoGen.h based on the module that's being used.

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
Sent: 24 December 2019 08:14
To: Devel EDK2 <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>
Subject: Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

https://clang.llvm.org/extra/clangd/<https://urldefense.proofpoint.com/v2/url?u=https-3A__clang.llvm.org_extra_clangd_&d=DwMFAg&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=SzAVyxtJHZm7PriTfxFyvkqqZ_OgUqnNtgjrlf7jVU4&m=hnezvCcoVJIKY_yJZu5tuv8S8Tit-sBbRAwCHamwdmk&s=TnaXlQG1xx6x6HWjkVx-915p4vBuyjSBIrGN6AG6CIg&e=>

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ni, Ray
Sent: Tuesday, December 24, 2019 4:14 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

All,
I am interested in using clangd to support symbolic navigation in Visual Studio Code.
But since EDKII doesn't have a master makefile, I am not sure how to enable clangd.
Anyone tried that recently?

Thanks,
Ray


[-- Attachment #2: Type: text/html, Size: 5350 bytes --]

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

[Tomas Pilar (tpilar)]

[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]

Oh but I am using clang-format to get vscode to format things according to proper code style.

From: Tomas Pilar
Sent: 24 December 2019 12:36
To: Devel EDK2 <devel@edk2.groups.io>; 'ray.ni@intel.com' <ray.ni@intel.com>
Subject: RE: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

I don't know about clangd but I am successfully using the vscode intellisense with EDKII including the multiple workspaces.

It took some time to configure things with paths and includes to make it work correctly but the only problem I have at the moment is to get it to use the correct AutoGen.h based on the module that's being used.

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ni, Ray
Sent: 24 December 2019 08:14
To: Devel EDK2 <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Subject: Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

https://clang.llvm.org/extra/clangd/<https://urldefense.proofpoint.com/v2/url?u=https-3A__clang.llvm.org_extra_clangd_&d=DwMFAg&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=SzAVyxtJHZm7PriTfxFyvkqqZ_OgUqnNtgjrlf7jVU4&m=hnezvCcoVJIKY_yJZu5tuv8S8Tit-sBbRAwCHamwdmk&s=TnaXlQG1xx6x6HWjkVx-915p4vBuyjSBIrGN6AG6CIg&e=>

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ni, Ray
Sent: Tuesday, December 24, 2019 4:14 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

All,
I am interested in using clangd to support symbolic navigation in Visual Studio Code.
But since EDKII doesn't have a master makefile, I am not sure how to enable clangd.
Anyone tried that recently?

Thanks,
Ray


[-- Attachment #2: Type: text/html, Size: 6387 bytes --]

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 2192 bytes --]

Can you please share the clang-format configuration file?

From: Tomas Pilar <tpilar@solarflare.com>
Sent: Tuesday, December 24, 2019 8:37 PM
To: Devel EDK2 <devel@edk2.groups.io>; Ni, Ray <ray.ni@intel.com>
Subject: RE: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

Oh but I am using clang-format to get vscode to format things according to proper code style.

From: Tomas Pilar
Sent: 24 December 2019 12:36
To: Devel EDK2 <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; 'ray.ni@intel.com' <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Subject: RE: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

I don't know about clangd but I am successfully using the vscode intellisense with EDKII including the multiple workspaces.

It took some time to configure things with paths and includes to make it work correctly but the only problem I have at the moment is to get it to use the correct AutoGen.h based on the module that's being used.

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ni, Ray
Sent: 24 December 2019 08:14
To: Devel EDK2 <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Subject: Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

https://clang.llvm.org/extra/clangd/<https://urldefense.proofpoint.com/v2/url?u=https-3A__clang.llvm.org_extra_clangd_&d=DwMFAg&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=SzAVyxtJHZm7PriTfxFyvkqqZ_OgUqnNtgjrlf7jVU4&m=hnezvCcoVJIKY_yJZu5tuv8S8Tit-sBbRAwCHamwdmk&s=TnaXlQG1xx6x6HWjkVx-915p4vBuyjSBIrGN6AG6CIg&e=>

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ni, Ray
Sent: Tuesday, December 24, 2019 4:14 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Subject: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

All,
I am interested in using clangd to support symbolic navigation in Visual Studio Code.
But since EDKII doesn't have a master makefile, I am not sure how to enable clangd.
Anyone tried that recently?

Thanks,
Ray


[-- Attachment #2: Type: text/html, Size: 7118 bytes --]

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

[Sean]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Thomas,

Are you able to share the Clang-format file?  I would like to get a format file as close to edk2 style as possible and then see if we can move the community to auto formatted code.  This could then be easily enforced by a PR gate that requires all modified/new files to conform to auto formatted code.  This would reduce the noise on the mailing list and make it easier to contribute to the project all while making edk2 more consistent.

Thanks
Sean

[-- Attachment #2: Type: text/html, Size: 513 bytes --]

Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?

[Tomas Pilar (tpilar)]

​Sorry Guys, I did not see the previous email. I don't claim my clang-format is perfect, you might need to tweak it a little.

-----------------------------------------------
BasedOnStyle: LLVM
AlignAfterOpenBracket: Align
AlignConsecutiveDeclarations: false
AlignEscapedNewlines: Left
AlignOperands: true
AlignTrailingComments: true
AllowAllParametersOfDeclarationOnNextLine: false
AllowShortBlocksOnASingleLine: false
AllowShortCaseLabelsOnASingleLine: true
AllowShortFunctionsOnASingleLine: None
AllowShortIfStatementsOnASingleLine: false
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterDefinitionReturnType: All
AlwaysBreakAfterReturnType: All
AlwaysBreakBeforeMultilineStrings: false
BinPackArguments: true
BinPackParameters: false
ExperimentalAutoDetectBinPacking: false
BreakBeforeBraces: Linux
BreakBeforeTernaryOperators: true
BreakStringLiterals: true
ColumnLimit: 0
CompactNamespaces: false
ContinuationIndentWidth: 2
Cpp11BracedListStyle: false
DerivePointerAlignment: true
FixNamespaceComments: true
IncludeBlocks: Regroup
IndentCaseLabels: true
IndentWidth: 2
IndentWrappedFunctionNames: false
KeepEmptyLinesAtTheStartOfBlocks: false
MaxEmptyLinesToKeep: 2
NamespaceIndentation: All
PointerAlignment: Right
ReflowComments: true
SortIncludes: true
SpaceAfterCStyleCast: true
SpaceBeforeAssignmentOperators: true
SpaceBeforeParens: ControlStatements
SpaceInEmptyParentheses: false
SpacesBeforeTrailingComments: 3
SpacesInCStyleCastParentheses: false
SpacesInContainerLiterals: true
SpacesInParentheses: false
SpacesInSquareBrackets: false
TabWidth: 2
​

Cheers,
Tom




From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Sean via Groups.Io <sean.brogan=microsoft.com@groups.io>
Sent: 07 January 2020 04:54
To: Ni; Ray; Devel EDK2
Subject: Re: [edk2-devel] Anyone successfully enabled clangd in edk2 code?
  
Thomas,

Are you able to share the Clang-format file?  I would like to get a format file as close to edk2 style as possible and then see if we can move the community to auto formatted code.  This could then be easily enforced by a PR gate that requires all modified/new  files to conform to auto formatted code.  This would reduce the noise on the mailing list and make it easier to contribute to the project all while making edk2 more consistent.  

Thanks
Sean