From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.7279.1577932781639845063 for ; Wed, 01 Jan 2020 18:39:41 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jan 2020 18:39:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,385,1571727600"; d="scan'208";a="224681559" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 01 Jan 2020 18:39:40 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jan 2020 18:39:40 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.210]) with mapi id 14.03.0439.000; Thu, 2 Jan 2020 10:39:39 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Wu, Hao A" CC: "Dong, Eric" , Laszlo Ersek , "Zeng, Star" , "Fu, Siyuan" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations Thread-Topic: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations Thread-Index: AQHVv3QlqswTM64xak+pAzSTLR/YBKfWrGDA Date: Thu, 2 Jan 2020 02:39:38 +0000 Deferred-Delivery: Thu, 2 Jan 2020 02:38:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3D0651@SHSMSX104.ccr.corp.intel.com> References: <20191231004914.8520-1-hao.a.wu@intel.com> In-Reply-To: <20191231004914.8520-1-hao.a.wu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, Hao > A > Sent: Tuesday, December 31, 2019 8:49 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; Ni= , > Ray ; Laszlo Ersek ; Zeng, Star > ; Fu, Siyuan ; Kinney, Michael > D > Subject: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations >=20 > Series is also available at: > https://github.com/hwu25/edk2/tree/mpinitlib_opt_v5 >=20 > V5 changes: > A. For patch 2, address a typo to resolve enlarging the microcode patch > information buffer too early when it is not full; > B. For patch 4, relocate the logic of storing detected microcode patch > before the application of microcode patch. >=20 > V4 history: > A. For patch 2, keep the calling sequence of functions: > MicrocodeDetect() and MtrrGetAllMtrrs() unchanged for BSP. > B. For patch 2, in function LoadMicrocodePatch(), add the missing logic > that handles the Extended Signature Table of a microcode patch. >=20 >=20 > V3 history: > For patch 3, correct license information for newly added header file. >=20 > V2 history: > A. For patch 2, rename function parameters and variables to better refle= ct > their usage; > B. For patch 2, remove unneeded check in LoadMicrocodePatchWorker(); > C. For patch 3, rename a couple of fields in the HOB structure; > D. For patch 3, update the 'ProcessorSpecificPatchOffset' field to point > to the microcode patch header instead of microcode patch data; > E. Add a new patch 5 to address an issue that certain fields in the > CPU_MP_DATA structure cannot be passed from PEI phase to DXE phase; > F. Add a new patch 6 to remove the redundant microcode related fields in > the CPU_MP_DATA structure. >=20 > V1 history: > This series will introduce a couple of optimizations to the MpInitLib wi= th > regard to microcode: >=20 > A. Reduce the copy size when loading the microcode patches data from fla= sh > into memory; > B. Produce a HOB to contain microcode patches information for subsequent > consumers of the microcode patches during the boot flow. >=20 > Uni-test done for the series: > A. System boot to OS/Shell successfully on a real platform; > B. Add debug message to verify the same microcode patch is applied to ea= ch > processor before and after the series. >=20 >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Star Zeng > Cc: Siyuan Fu > Cc: Michael D Kinney >=20 > Hao A Wu (6): > UefiCpuPkg/MpInitLib: Collect processors' CPUID & Platform ID info > UefiCpuPkg/MpInitLib: Reduce the size when loading microcode patches > UefiCpuPkg: Add definitions for EDKII microcode patch HOB > UefiCpuPkg/MpInitLib: Produce EDKII microcode patch HOB > UefiCpuPkg/MpInitLib: Relocate microcode patch fields in CPU_MP_DATA > UefiCpuPkg/MpInitLib: Remove redundant microcode fields in > CPU_MP_DATA >=20 > UefiCpuPkg/UefiCpuPkg.dec | 3 + > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 + > UefiCpuPkg/Include/Guid/MicrocodePatchHob.h | 44 +++ > UefiCpuPkg/Library/MpInitLib/MpLib.h | 59 +++- > UefiCpuPkg/Library/MpInitLib/Microcode.c | 351 ++++++++++++++++++- > - > UefiCpuPkg/Library/MpInitLib/MpLib.c | 110 +++--- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 55 +++ > 7 files changed, 513 insertions(+), 110 deletions(-) > create mode 100644 UefiCpuPkg/Include/Guid/MicrocodePatchHob.h >=20 > -- > 2.12.0.windows.1 >=20 >=20 >=20