public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Voelz, Jason" <jason.voelz@intel.com>
Subject: Re: [Patch 1/2] MdePkg BaseLib.h: Update IA32_CR4 strut to include all public fields
Date: Wed, 8 Jan 2020 14:12:21 +0000	[thread overview]
Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3E0243@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191223065537.32468-2-liming.gao@intel.com>

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Monday, December 23, 2019 2:56 PM
> To: devel@edk2.groups.io
> Cc: Voelz, Jason <jason.voelz@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [Patch 1/2] MdePkg BaseLib.h: Update IA32_CR4 strut to include all public fields
> 
> From: Jason Voelz <jason.voelz@intel.com>
> 
> Based on Intel Software Develeper's Manual, add all fields in IA32_CR4.
> 
> Signed-off-by: Jason Voelz <jason.voelz@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdePkg/Include/Library/BaseLib.h | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/BaseLib.h
> index 2a75bc023f..ecadff8b23 100644
> --- a/MdePkg/Include/Library/BaseLib.h
> +++ b/MdePkg/Include/Library/BaseLib.h
> @@ -5387,10 +5387,19 @@ typedef union {
>      UINT32  OSXMMEXCPT:1;   ///< Operating System Support for
>                              ///< Unmasked SIMD Floating Point
>                              ///< Exceptions.
> -    UINT32  Reserved_2:1;   ///< Reserved.
> +    UINT32  UMIP:1;         ///< User-Mode Instruction Prevention.
>      UINT32  LA57:1;         ///< Linear Address 57bit.
> -    UINT32  VMXE:1;         ///< VMX Enable
> -    UINT32  Reserved_1:18;  ///< Reserved.
> +    UINT32  VMXE:1;         ///< VMX Enable.
> +    UINT32  SMXE:1;         ///< SMX Enable.
> +    UINT32  Reserved_3:1;   ///< Reserved.
> +    UINT32  FSGSBASE:1;     ///< FSGSBASE Enable.
> +    UINT32  PCIDE:1;        ///< PCID Enable.
> +    UINT32  OSXSAVE:1;      ///< XSAVE and Processor Extended States Enable.
> +    UINT32  Reserved_4:1;   ///< Reserved.
> +    UINT32  SMEP:1;         ///< SMEP Enable.
> +    UINT32  SMAP:1;         ///< SMAP Enable.
> +    UINT32  PKE:1;          ///< Protection-Key Enable.
> +    UINT32  Reserved_5:9;   ///< Reserved.
>    } Bits;
>    UINTN     UintN;
>  } IA32_CR4;
> --
> 2.13.0.windows.1


  reply	other threads:[~2020-01-08 14:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23  6:55 [Patch 0/2] UefiCpuPkg/CpuCommonFeaturesLib: Set SMXE bit of CR4 when SMX is enabled Liming Gao
2019-12-23  6:55 ` [Patch 1/2] MdePkg BaseLib.h: Update IA32_CR4 strut to include all public fields Liming Gao
2020-01-08 14:12   ` Ni, Ray [this message]
2019-12-23  6:55 ` [Patch 2/2] UefiCpuPkg/CpuCommonFeaturesLib: SMXE bit of CR4 should set Liming Gao
2020-01-08 14:12   ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=734D49CCEBEEF84792F5B80ED585239D5C3E0243@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox