From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.3919.1578618618892121038 for ; Thu, 09 Jan 2020 17:10:19 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 17:10:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,414,1571727600"; d="scan'208";a="218522480" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 09 Jan 2020 17:10:18 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 17:10:18 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 17:10:17 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.39]) with mapi id 14.03.0439.000; Fri, 10 Jan 2020 09:10:16 +0800 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Dong, Eric" CC: Laszlo Ersek Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter. Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter. Thread-Index: AQHVxq1nXwdOKeJVMUWJ+ymyAaJYHKfjFpig Date: Fri, 10 Jan 2020 01:10:15 +0000 Deferred-Delivery: Fri, 10 Jan 2020 01:05:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3E2090@SHSMSX104.ccr.corp.intel.com> References: <20200109052641.767-1-eric.dong@intel.com> In-Reply-To: <20200109052641.767-1-eric.dong@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Dong, Eric > Sent: Thursday, January 9, 2020 1:27 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comme= nts for parameter. >=20 > This issue caused by below change: > SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6 > * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2388 >=20 > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Eric Dong > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuD= xeSmm/MpService.c > index 35a6996ba3..c285a70ebb 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1142,6 +1142,8 @@ FindFirstFreeToken ( >=20 >=20 > If no free token, allocate new tokens then return the free one. >=20 >=20 >=20 > + @param RunningApsCount The Running Aps count for this token. >=20 > + >=20 > @retval return the first free PROCEDURE_TOKEN. >=20 >=20 >=20 > **/ >=20 > -- > 2.23.0.windows.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#53046): https://edk2.groups.io/g/devel/message/53046 > Mute This Topic: https://groups.io/mt/69569495/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D