Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Javeed, Ashraf <ashraf.javeed@intel.com>
> Sent: Friday, January 10, 2020 1:01 PM
> To: devel@edk2.groups.io; Javeed, Ashraf <ashraf.javeed@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1] MdePkg/Protocols: New PCI Express Platform
> Protocol, EFI encodings
> 
> Hi Liming,
> Here is the updated commit with its title / message corrected, in the following edk2-staging repo:
> https://github.com/ashrafj/edk2-staging/commit/532f2d87a895a1e7b6846ca19c9bbc02f8702a3a
> 
> Thanks
> Ashraf
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Javeed,
> > Ashraf
> > Sent: Friday, January 10, 2020 10:26 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1]
> > MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1954
> >
> > Three interfaces added to PCI Express Platform Protocol:-
> > (1) GetDevicePolicy() -> to retrieve device-specific platform policies
> > (2) NotifyDeviceState() -> to notify platform about device PCI Express
> >     configuration state
> > (3) GetPolicy() -> to retrieve platform policy about the PCI Express
> >     feature list
> > PCI Express Override Protocol is made alias to PCI Express Platform Protocol.
> > EFI encodings introduced for the following PCI Express features, are:
> > 1.	Maximum Payload Size (MPS)
> > 2.	Maximum Read Request Size (MRRS)
> > 3.	Extended Tag
> > 4.	Relax Order Enable
> > 5.	No Snoop Enable
> > 6.	ASPM support
> > 7.	Common Clock Configuration
> > 8.	Extended SYNC
> > 9.	Atomic Op
> > 10.	LTR Enable
> > 11.	PTM support
> > 12.	CTO support
> > 13.	CPM
> > 14.	L1 PM Substates
> >
> > New source files with unique definitions are:
> > MdePkg/Include/Protocol/PciExpressPlatform.h,
> > MdePkg/Include/Protocol/PciExpressOverride.h
> >
> > Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > ---
> >
> > In V1: Code Syntax correction made.
> > ---
> >  MdePkg/Include/Protocol/PciExpressPlatform.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h
> > b/MdePkg/Include/Protocol/PciExpressPlatform.h
> > index 8a28418..dc58268 100644
> > --- a/MdePkg/Include/Protocol/PciExpressPlatform.h
> > +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h
> > @@ -643,11 +643,11 @@ typedef struct {
> >   **/
> >  typedef
> >  EFI_STATUS
> > -(EFIAPI * EFI_PCI_EXPRESS_GET_POLICY) {
> > +(EFIAPI * EFI_PCI_EXPRESS_GET_POLICY) (
> >    IN CONST  EFI_PCI_EXPRESS_PLATFORM_PROTOCOL     *This,
> >    IN        UINTN                                 Size,
> >    IN OUT    EFI_PCI_EXPRESS_PLATFORM_POLICY       *PlatformPolicy
> > -};
> > +);
> >
> >  ///
> >  /// This protocol provides the interface between the PCI bus driver/PCI Host
> > --
> > 2.21.0.windows.1
> >
> >
> >