From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.8081.1578649504354205560 for ; Fri, 10 Jan 2020 01:45:04 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 01:45:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="scan'208";a="272359076" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 10 Jan 2020 01:45:03 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jan 2020 01:45:03 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by shsmsx102.ccr.corp.intel.com ([169.254.2.202]) with mapi id 14.03.0439.000; Fri, 10 Jan 2020 17:45:01 +0800 From: "Ni, Ray" To: "Javeed, Ashraf" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings Thread-Topic: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings Thread-Index: AQHVx3JHpdjS0UDuP0+ODLpV/BjpMqfjVnyQgABP3mA= Date: Fri, 10 Jan 2020 09:45:00 +0000 Deferred-Delivery: Fri, 10 Jan 2020 09:45:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C3E84F2@SHSMSX104.ccr.corp.intel.com> References: <15E86D980593861E.18217@groups.io> <95C5C2B113DE604FB208120C742E98245798D892@BGSMSX101.gar.corp.intel.com> In-Reply-To: <95C5C2B113DE604FB208120C742E98245798D892@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Javeed, Ashraf > Sent: Friday, January 10, 2020 1:01 PM > To: devel@edk2.groups.io; Javeed, Ashraf > Cc: Kinney, Michael D ; Gao, Liming ; Ni, Ray > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1] Mde= Pkg/Protocols: New PCI Express Platform > Protocol, EFI encodings >=20 > Hi Liming, > Here is the updated commit with its title / message corrected, in the fo= llowing edk2-staging repo: > https://github.com/ashrafj/edk2-staging/commit/532f2d87a895a1e7b6846ca19= c9bbc02f8702a3a >=20 > Thanks > Ashraf >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Javeed, > > Ashraf > > Sent: Friday, January 10, 2020 10:26 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > ; Ni, Ray > > Subject: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V1] > > MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1954 > > > > Three interfaces added to PCI Express Platform Protocol:- > > (1) GetDevicePolicy() -> to retrieve device-specific platform policies > > (2) NotifyDeviceState() -> to notify platform about device PCI Express > > configuration state > > (3) GetPolicy() -> to retrieve platform policy about the PCI Express > > feature list > > PCI Express Override Protocol is made alias to PCI Express Platform Pr= otocol. > > EFI encodings introduced for the following PCI Express features, are: > > 1. Maximum Payload Size (MPS) > > 2. Maximum Read Request Size (MRRS) > > 3. Extended Tag > > 4. Relax Order Enable > > 5. No Snoop Enable > > 6. ASPM support > > 7. Common Clock Configuration > > 8. Extended SYNC > > 9. Atomic Op > > 10. LTR Enable > > 11. PTM support > > 12. CTO support > > 13. CPM > > 14. L1 PM Substates > > > > New source files with unique definitions are: > > MdePkg/Include/Protocol/PciExpressPlatform.h, > > MdePkg/Include/Protocol/PciExpressOverride.h > > > > Signed-off-by: Ashraf Javeed > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Ray Ni > > --- > > > > In V1: Code Syntax correction made. > > --- > > MdePkg/Include/Protocol/PciExpressPlatform.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h > > b/MdePkg/Include/Protocol/PciExpressPlatform.h > > index 8a28418..dc58268 100644 > > --- a/MdePkg/Include/Protocol/PciExpressPlatform.h > > +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h > > @@ -643,11 +643,11 @@ typedef struct { > > **/ > > typedef > > EFI_STATUS > > -(EFIAPI * EFI_PCI_EXPRESS_GET_POLICY) { > > +(EFIAPI * EFI_PCI_EXPRESS_GET_POLICY) ( > > IN CONST EFI_PCI_EXPRESS_PLATFORM_PROTOCOL *This, > > IN UINTN Size, > > IN OUT EFI_PCI_EXPRESS_PLATFORM_POLICY *PlatformPolicy > > -}; > > +); > > > > /// > > /// This protocol provides the interface between the PCI bus driver/P= CI Host > > -- > > 2.21.0.windows.1 > > > > > >=20