From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.15144.1581295192358881599 for ; Sun, 09 Feb 2020 16:39:52 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2020 16:39:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,423,1574150400"; d="scan'208";a="232949921" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 09 Feb 2020 16:39:51 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 9 Feb 2020 16:39:50 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 9 Feb 2020 16:39:51 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.5]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.97]) with mapi id 14.03.0439.000; Mon, 10 Feb 2020 08:39:48 +0800 From: "Ni, Ray" To: "Javeed, Ashraf" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member Thread-Topic: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code correction - removal of reserved member Thread-Index: AQHV3Nl9Pr0OcTmIHUKse5NEnFrcBagTm2sQ Date: Mon, 10 Feb 2020 00:39:48 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C4289FA@SHSMSX104.ccr.corp.intel.com> References: <20200206103739.18732-1-ashraf.javeed@intel.com> In-Reply-To: <20200206103739.18732-1-ashraf.javeed@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Javeed, Ashraf > Sent: Thursday, February 6, 2020 6:38 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming ; Ni, Ray > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code c= orrection - removal of reserved member >=20 > Signed-off-by: Ashraf Javeed > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Ray Ni > --- > MdePkg/Include/Protocol/PciExpressPlatform.h | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) >=20 > diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h b/MdePkg/Includ= e/Protocol/PciExpressPlatform.h > index dc58268..bb2c8c8 100644 > --- a/MdePkg/Include/Protocol/PciExpressPlatform.h > +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h > @@ -360,14 +360,10 @@ struct _EFI_PCI_EXPRESS_L1PM_SUBSTATES { > }; >=20 > /// > -/// Reserves for future use > -/// > -typedef UINT8 EFI_PCI_EXPRESS_RESERVES; > - > -/// > -/// The EFI_PCI_EXPRESS_DEVICE_POLICY is altogether 128-byte size, with = each > -/// byte field representing one PCI standerd feature defined in the PCI = Express Base > -/// Specification 4.0, version 1.0. > +/// The EFI_PCI_EXPRESS_DEVICE_POLICY size is fixed as per its definitio= n corresponding > +/// to its version, with each byte field represents one PCI Express feat= ure and > +/// its bitmask define the legal combinations to represent all the valid= combinations > +/// of its attributes, defined in the PCI Express Base Specification. > /// > typedef struct { > EFI_PCI_EXPRESS_MAX_PAYLOAD_SIZE DeviceCtlMPS; > @@ -384,7 +380,6 @@ typedef struct { > EFI_PCI_EXPRESS_CTO_SUPPORT CTOsupport; > EFI_PCI_EXPRESS_CPM LinkCtlCPM; > EFI_PCI_EXPRESS_L1PM_SUBSTATES L1PMSubstates; > - EFI_PCI_EXPRESS_RESERVES Reserves[114]; > } EFI_PCI_EXPRESS_DEVICE_POLICY; >=20 > /// > -- > 2.21.0.windows.1