From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.18014.1581316591240395111 for ; Sun, 09 Feb 2020 22:36:31 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2020 22:36:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,424,1574150400"; d="scan'208";a="233008082" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 09 Feb 2020 22:36:30 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 9 Feb 2020 22:36:29 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 9 Feb 2020 22:36:29 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.5]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.138]) with mapi id 14.03.0439.000; Mon, 10 Feb 2020 14:36:27 +0800 From: "Ni, Ray" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Kinney, Michael D" , "Dong, Eric" , "Laszlo Ersek" Subject: Re: [PATCH v1 1/2] Revert UefiCpuPkg/MpInitLib: Relocate microcode patch fields in CPU_MP_DATA Thread-Topic: [PATCH v1 1/2] Revert UefiCpuPkg/MpInitLib: Relocate microcode patch fields in CPU_MP_DATA Thread-Index: AQHV3K2n7oJYkp80OEirrQxp/J/4cKgT/1gQ Date: Mon, 10 Feb 2020 06:36:26 +0000 Deferred-Delivery: Mon, 10 Feb 2020 06:36:00 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C428F6D@SHSMSX104.ccr.corp.intel.com> References: <20200206052356.3672-1-hao.a.wu@intel.com> <20200206052356.3672-2-hao.a.wu@intel.com> In-Reply-To: <20200206052356.3672-2-hao.a.wu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, February 6, 2020 1:24 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Kubacki, Michael A ; Kinney, Michael D > ; Dong, Eric ; Ni, Ray <= ray.ni@intel.com>; Laszlo Ersek > > Subject: [PATCH v1 1/2] Revert UefiCpuPkg/MpInitLib: Relocate microcode p= atch fields in CPU_MP_DATA >=20 > This reverts commit 88bd06616617ef2569f093f7b51893c11ad78e26. >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2465 >=20 > Commit 88bd0661661 relocates the 'MicrocodePatchAddress' and > 'MicrocodePatchRegionSize' fields in structure CPU_MP_DATA to ensure that > they can be properly passed between different architectures. >=20 > However, such change is not backward compatible with the scenario like > pre-existing binaries such as FSP. These binaries are built when the code > base has a different version of the CPU_MP_DATA structure definition. Thi= s > may cause issues when accessing the 'MicrocodePatchAddress' and > 'MicrocodePatchRegionSize' fields, since their offsets are different > (between PEI phase in the FSP binaries and DXE phase in current code > implementation). >=20 > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Hao A Wu > --- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/Mp= InitLib/MpLib.h > index 7c62d75acc..d7e20f0b74 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h > @@ -219,8 +219,6 @@ struct _CPU_MP_DATA { > UINT64 CpuInfoInHob; > UINT32 CpuCount; > UINT32 BspNumber; > - UINT64 MicrocodePatchAddress; > - UINT64 MicrocodePatchRegionSize; > // > // The above fields data will be passed from PEI to DXE > // Please make sure the fields offset same in the different > @@ -264,6 +262,8 @@ struct _CPU_MP_DATA { > UINT8 Vector; > BOOLEAN PeriodicMode; > BOOLEAN TimerInterruptState; > + UINT64 MicrocodePatchAddress; > + UINT64 MicrocodePatchRegionSize; >=20 > // > // Whether need to use Init-Sipi-Sipi to wake up the APs. > -- > 2.12.0.windows.1