From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web09.18617.1581319212365597664 for ; Sun, 09 Feb 2020 23:20:12 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2020 23:20:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,424,1574150400"; d="scan'208";a="227103491" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 09 Feb 2020 23:20:10 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 9 Feb 2020 23:20:10 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 9 Feb 2020 23:20:10 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.5]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.76]) with mapi id 14.03.0439.000; Mon, 10 Feb 2020 15:20:08 +0800 From: "Ni, Ray" To: "Javeed, Ashraf" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] MdeModulePkg/PciBusDxe: Setup for PCI Express features Thread-Topic: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 01/12] MdeModulePkg/PciBusDxe: Setup for PCI Express features Thread-Index: AQHV3fOOWzlhRqhvAEiUeeXVOax+hqgUBWrg Date: Mon, 10 Feb 2020 07:20:08 +0000 Message-ID: <734D49CCEBEEF84792F5B80ED585239D5C429202@SHSMSX104.ccr.corp.intel.com> References: <20200207200447.10536-1-ashraf.javeed@intel.com> <15F1377EA7D1AA4F.7869@groups.io> <95C5C2B113DE604FB208120C742E9824579AAF65@BGSMSX101.gar.corp.intel.com> In-Reply-To: <95C5C2B113DE604FB208120C742E9824579AAF65@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: ray.ni@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > > + PCI_CAPABILITY_PCIEXP PciExpressCapabilityStruct= ure; 1. To Align with existing field "Pci", how about rename it to "PciExpressCapability" (no "Structure" suffix)? 2. I see that only GetPciExpressProtocol() in PciPlatformSupport.c is used = in this patch. All other functions in PciFeatureSupport.c andPciPlatformSupport.c are = not used. It makes the reviewers confused about how those unused functions can be= used. You should remove these unused functions in this patch and add them in = later patches when the code logic calls them. Thanks, Ray