Re: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Jiang, Guomin <guomin.jiang@intel.com>
> Sent: Wednesday, March 18, 2020 4:08 PM
> To: devel@edk2.groups.io
> Cc: Jiang, Guomin <guomin.jiang@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
> 
> From: Guomin Jiang <guomin.jiang@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589
> 
> According to code logic, it just judge the condition rather than the
> status, it should use the ASSERT rather than ASSERT_EFI_ERROR.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
> ---
>  .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> index 29b6916f61..aa2bf14fa8 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> @@ -69,7 +69,7 @@ RecordPciDeviceInList(
>    ASSERT_EFI_ERROR(Status);
> 
> 
> 
>    NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice));
> 
> -  ASSERT_EFI_ERROR(NewPciDevice != NULL);
> 
> +  ASSERT(NewPciDevice != NULL);
> 
> 
> 
>    NewPciDevice->Signature   = PCI_DEVICE_INSTANCE_SIGNATURE;
> 
>    NewPciDevice->PciSegment  = PciSegment;
> 
> --
> 2.25.1.windows.1